Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, May 27, 2017 at 06:38:06PM -0400, Oleg Drokin wrote:
> 
> On May 27, 2017, at 4:26 PM, Greg KH wrote:
> 
> > On Sat, May 27, 2017 at 03:22:18PM -0400, Oleg Drokin wrote:
> >> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
> >> lov_user_md pointer from user- or kernel-space.  This changes the
> >> behavior of copy_from_user() on SPARC and may result in a misaligned
> >> access exception which in turn oopses the kernel.  In fact the
> >> relevant argument to lov_getstripe() is never called with a
> >> kernel-space pointer and so changing the address limits is unnecessary
> >> and so we remove the calls to save, set, and restore the address
> >> limits.
> >> 
> >> Signed-off-by: John L. Hammond <john.hammond@intel.com>
> >> Reviewed-on: http://review.whamcloud.com/6150
> >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
> >> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> >> Reviewed-by: Li Wei <wei.g.li@intel.com>
> >> CC: linux-stable <stable@vger.kernel.org> # >= v3.11
> >> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> >> ---
> >> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
> >> 1 file changed, 9 deletions(-)
> > 
> > What was the git commit id of this patch in Linus's tree?
> 
> It's not in Linus tree yet.
> I was just informed that this patch should go to stable by Al, so I added stable
> to the list.

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>