From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>,
linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH 4/9] MIPS: Send SIGILL for BPOSGE32 in `__compute_return_epc_for_insn'
Date: Thu, 8 Jun 2017 15:11:41 +0200 [thread overview]
Message-ID: <20170608131141.GB8108@linux-mips.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1706050258410.10864@tp.orcam.me.uk>
On Tue, Jun 06, 2017 at 12:17:05AM +0100, Maciej W. Rozycki wrote:
> Fix commit e50c0a8fa60d ("Support the MIPS32 / MIPS64 DSP ASE.") and
> send SIGILL rather than SIGBUS whenever an unimplemented BPOSGE32 DSP
> ASE instruction has been encountered in `__compute_return_epc_for_insn'
> as our Reserved Instruction exception handler would in response to an
> attempt to actually execute the instruction. Sending SIGBUS only makes
> sense for the unaligned PC case, since moved to `__compute_return_epc'.
> Adjust function documentation accordingly, correct formatting and use
> `pr_info' rather than `printk' as the other exit path already does.
>
> Cc: stable@vger.kernel.org # 2.6.14+
> Fixes: e50c0a8fa60d ("Support the MIPS32 / MIPS64 DSP ASE.")
> Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
> ---
> I hope folding the formatting fix and `pr_info' update with the base
> change is fine given that they all apply to the same code line.
Ok, but ...
> sigill_dsp:
> - printk("%s: DSP branch but not DSP ASE - sending SIGBUS.\n", current->comm);
> - force_sig(SIGBUS, current);
> + pr_info("%s: DSP branch but not DSP ASE - sending SIGILL.\n",
> + current->comm);
Shouldn't this then maybe be a pr_debug then? With pr_info the right
kind of program can produce lots of useless clutter.
Ralf
next prev parent reply other threads:[~2017-06-08 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.1706040314270.10864@tp.orcam.me.uk>
2017-06-05 23:15 ` [PATCH 1/9] MIPS: math-emu: Prevent wrong ISA mode instruction emulation Maciej W. Rozycki
2017-06-05 23:15 ` [PATCH 2/9] MIPS: Actually decode JALX in `__compute_return_epc_for_insn' Maciej W. Rozycki
2017-06-05 23:16 ` [PATCH 3/9] MIPS: Fix unaligned PC interpretation in `compute_return_epc' Maciej W. Rozycki
2017-06-05 23:17 ` [PATCH 4/9] MIPS: Send SIGILL for BPOSGE32 in `__compute_return_epc_for_insn' Maciej W. Rozycki
2017-06-08 13:11 ` Ralf Baechle [this message]
2017-06-08 15:03 ` Maciej W. Rozycki
2017-06-05 23:17 ` [PATCH 5/9] MIPS: Rename `sigill_r6' to `sigill_r2r6' " Maciej W. Rozycki
2017-06-06 6:06 ` Greg KH
2017-06-06 16:13 ` Maciej W. Rozycki
2017-06-05 23:18 ` [PATCH 6/9] MIPS: Send SIGILL for linked branches " Maciej W. Rozycki
2017-06-05 23:19 ` [PATCH 7/9] MIPS: Send SIGILL for R6 " Maciej W. Rozycki
2017-06-05 23:19 ` [PATCH 8/9] MIPS: Fix a typo: s/preset/present/ in r2-to-r6 emulation error message Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608131141.GB8108@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).