[PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
@ 2017-06-12  9:16 Johan Hovold
  2017-06-12  9:50 ` Bjørn Mork
  2017-06-12 10:11 ` Teemu Likonen
  0 siblings, 2 replies; 11+ messages in thread
From: Johan Hovold @ 2017-06-12  9:16 UTC (permalink / raw)
  To: Teemu Likonen
  Cc: linux-usb, Dan Williams, Bjørn Mork, Johan Hovold, stable

Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
Longcheer vendor id.

Reported-by: Teemu Likonen <tlikonen@iki.fi>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)

Teemu, would you be able to test this patch?

Thanks,
Johan


diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 3bf61acfc26b..b48f3557b2e4 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
 /* SpeedUp SU9800 usb 3g modem */
 #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
 /* Haier products */
 #define HAIER_VENDOR_ID				0x201e
 #define HAIER_PRODUCT_CE81B			0x10f8
@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
 	},
 	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
-- 
2.13.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12  9:16 [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id Johan Hovold
@ 2017-06-12  9:50 ` Bjørn Mork
  2017-06-12 10:09   ` Oliver Neukum
                     ` (3 more replies)
  2017-06-12 10:11 ` Teemu Likonen
  1 sibling, 4 replies; 11+ messages in thread
From: Bjørn Mork @ 2017-06-12  9:50 UTC (permalink / raw)
  To: Johan Hovold; +Cc: Teemu Likonen, linux-usb, Dan Williams, stable

Johan Hovold <johan@kernel.org> writes:

> Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
> Longcheer vendor id.
>
> Reported-by: Teemu Likonen <tlikonen@iki.fi>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/option.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> Teemu, would you be able to test this patch?
>
> Thanks,
> Johan
>
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 3bf61acfc26b..b48f3557b2e4 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
>  /* SpeedUp SU9800 usb 3g modem */
>  #define SPEEDUP_PRODUCT_SU9800			0x9800
>  
> +/* Telewell */
> +#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
> +
>  /* Haier products */
>  #define HAIER_VENDOR_ID				0x201e
>  #define HAIER_PRODUCT_CE81B			0x10f8
> @@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
>  	},
>  	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
> +	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
>  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
>  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
>  	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },


I was looking at the Windows drivers on
https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
whiche have this among the serial stuff:

[QCOM]
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06

%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05


It's not clear what type of driver the 'cmntnet.sys' installed by this
is, but I wonder if it maybe is QMI based on the 'qc' prefix?


And maybe we should add the remaining device IDs too?



Bjørn

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12  9:50 ` Bjørn Mork
@ 2017-06-12 10:09   ` Oliver Neukum
  2017-06-12 10:12   ` Johan Hovold
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 11+ messages in thread
From: Oliver Neukum @ 2017-06-12 10:09 UTC (permalink / raw)
  To: Bjørn Mork, Johan Hovold
  Cc: Teemu Likonen, Dan Williams, linux-usb, stable

Am Montag, den 12.06.2017, 11:50 +0200 schrieb Bjørn Mork:
> It's not clear what type of driver the 'cmntnet.sys' installed by this
> is, but I wonder if it maybe is QMI based on the 'qc' prefix?

QualCom

I am afraid it says nothing about the protocol.

	Regards
		Oliver

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12  9:50 ` Bjørn Mork
  2017-06-12 10:09   ` Oliver Neukum
@ 2017-06-12 10:12   ` Johan Hovold
  2017-06-12 10:14   ` Johan Hovold
  2017-06-12 10:31   ` Lars Melin
  3 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2017-06-12 10:12 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Johan Hovold, Teemu Likonen, linux-usb, Dan Williams, stable

[ +CC: Lars ]

On Mon, Jun 12, 2017 at 11:50:13AM +0200, Bjï¿½rn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
> 
> > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
> > Longcheer vendor id.
> >
> > Reported-by: Teemu Likonen <tlikonen@iki.fi>
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/usb/serial/option.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > Teemu, would you be able to test this patch?
> >
> > Thanks,
> > Johan
> >
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 3bf61acfc26b..b48f3557b2e4 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
> >  /* SpeedUp SU9800 usb 3g modem */
> >  #define SPEEDUP_PRODUCT_SU9800			0x9800
> >  
> > +/* Telewell */
> > +#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
> > +
> >  /* Haier products */
> >  #define HAIER_VENDOR_ID				0x201e
> >  #define HAIER_PRODUCT_CE81B			0x10f8
> > @@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
> >  	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
> >  	},
> >  	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
> > +	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
> >  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
> >  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
> >  	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
> 
> 
> I was looking at the Windows drivers on
> https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
> whiche have this among the serial stuff:
> 
> [QCOM]
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06
> 
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
> 
> 
> It's not clear what type of driver the 'cmntnet.sys' installed by this
> is, but I wonder if it maybe is QMI based on the 'qc' prefix?

I think Lars just suggested that.

> And maybe we should add the remaining device IDs too?

Good idea, I'll respin.

Thanks,
Johan

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12  9:50 ` Bjørn Mork
  2017-06-12 10:09   ` Oliver Neukum
  2017-06-12 10:12   ` Johan Hovold
@ 2017-06-12 10:14   ` Johan Hovold
  2017-06-12 10:31   ` Lars Melin
  3 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2017-06-12 10:14 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Johan Hovold, Teemu Likonen, linux-usb, Dan Williams, stable,
	Lars Melin

[ +CC: Lars, resend with Lars actually on CC ]

On Mon, Jun 12, 2017 at 11:50:13AM +0200, Bjï¿½rn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
> 
> > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
> > Longcheer vendor id.
> >
> > Reported-by: Teemu Likonen <tlikonen@iki.fi>
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/usb/serial/option.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > Teemu, would you be able to test this patch?
> >
> > Thanks,
> > Johan
> >
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 3bf61acfc26b..b48f3557b2e4 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
> >  /* SpeedUp SU9800 usb 3g modem */
> >  #define SPEEDUP_PRODUCT_SU9800			0x9800
> >  
> > +/* Telewell */
> > +#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
> > +
> >  /* Haier products */
> >  #define HAIER_VENDOR_ID				0x201e
> >  #define HAIER_PRODUCT_CE81B			0x10f8
> > @@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
> >  	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
> >  	},
> >  	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
> > +	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
> >  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
> >  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
> >  	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
> 
> 
> I was looking at the Windows drivers on
> https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
> whiche have this among the serial stuff:
> 
> [QCOM]
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06
> 
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
> 
> 
> It's not clear what type of driver the 'cmntnet.sys' installed by this
> is, but I wonder if it maybe is QMI based on the 'qc' prefix?

I think Lars just suggested that.

> And maybe we should add the remaining device IDs too?

Good idea, I'll respin.

Thanks,
Johan

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12  9:50 ` Bjørn Mork
                     ` (2 preceding siblings ...)
  2017-06-12 10:14   ` Johan Hovold
@ 2017-06-12 10:31   ` Lars Melin
  2017-06-12 10:37     ` Bjørn Mork
  3 siblings, 1 reply; 11+ messages in thread
From: Lars Melin @ 2017-06-12 10:31 UTC (permalink / raw)
  To: Bjørn Mork, Johan Hovold
  Cc: Teemu Likonen, linux-usb, Dan Williams, stable

On 2017-06-12 16:50, Bjørn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
> 
>> Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
>> Longcheer vendor id.
>>
>> Reported-by: Teemu Likonen <tlikonen@iki.fi>
>> Cc: stable <stable@vger.kernel.org>
>> Signed-off-by: Johan Hovold <johan@kernel.org>
>> ---
>>   drivers/usb/serial/option.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> Teemu, would you be able to test this patch?
>>
>> Thanks,
>> Johan
>>
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index 3bf61acfc26b..b48f3557b2e4 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
>>   /* SpeedUp SU9800 usb 3g modem */
>>   #define SPEEDUP_PRODUCT_SU9800			0x9800
>>   
>> +/* Telewell */
>> +#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
>> +
>>   /* Haier products */
>>   #define HAIER_VENDOR_ID				0x201e
>>   #define HAIER_PRODUCT_CE81B			0x10f8
>> @@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
>>   	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
>>   	},
>>   	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
>> +	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
>>   	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
>>   	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
>>   	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
> 
> 
> I was looking at the Windows drivers on
> https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
> whiche have this among the serial stuff:
> 
> [QCOM]
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06
> 
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
> 
> 
> It's not clear what type of driver the 'cmntnet.sys' installed by this
> is, but I wonder if it maybe is QMI based on the 'qc' prefix?
> 
> 
> And maybe we should add the remaining device IDs too?
> 
> 
> 
> Bjørn
> 

1c9e:9803 can be added, the other ones may be reserved id's for
products that never reached the market.

/Lars

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12 10:31   ` Lars Melin
@ 2017-06-12 10:37     ` Bjørn Mork
  2017-06-12 11:02       ` Lars Melin
  0 siblings, 1 reply; 11+ messages in thread
From: Bjørn Mork @ 2017-06-12 10:37 UTC (permalink / raw)
  To: Lars Melin; +Cc: Johan Hovold, Teemu Likonen, linux-usb, Dan Williams, stable

Lars Melin <larsm17@gmail.com> writes:

> 1c9e:9803 can be added, the other ones may be reserved id's for
> products that never reached the market.

Out of curiosity: How do you know these things?

Thanks for very valuable information.  Our lists of supported devices
are long enough without lots of dead entries...


Bjørn

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12 10:37     ` Bjørn Mork
@ 2017-06-12 11:02       ` Lars Melin
  2017-06-12 14:29         ` Johan Hovold
  0 siblings, 1 reply; 11+ messages in thread
From: Lars Melin @ 2017-06-12 11:02 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Johan Hovold, Teemu Likonen, linux-usb, Dan Williams, stable

On 2017-06-12 17:37, Bjørn Mork wrote:
> Lars Melin <larsm17@gmail.com> writes:
> 
>> 1c9e:9803 can be added, the other ones may be reserved id's for
>> products that never reached the market.
> 
> Out of curiosity: How do you know these things?
> 
> Thanks for very valuable information.  Our lists of supported devices
> are long enough without lots of dead entries...
> 
> 
> Bjørn
> 

The driver is almost 6 years old and only the first two id's has 
surfaced on the net or in all the GPL code I have from some of the major 
Chinese 3G router manufacturers.
1c9e:9801 is btw included in a mfgr specific qmi_wwan driver together
with some other id's which may interest you.
Tell me if you want to get that driver and I'll mail it to you.

The driver is written by Qualcomm for Longcheer and Qualcomm is known 
for including device id's that either never become used or (even worser) 
will be used for a product with an interface layout not matching what 
was listed in the big Qualcomm driver .inf file

I have never seen qcwwan.ndi used for anything else than rmnet/qmiwwan 
and a single interface without altsetting and with 3 interfaces whereof 
one is of interrupt type and with interface attributes ff/ff/ff can't 
possibly be for any other net type protocol.

/Lars

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12 11:02       ` Lars Melin
@ 2017-06-12 14:29         ` Johan Hovold
  0 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2017-06-12 14:29 UTC (permalink / raw)
  To: Lars Melin
  Cc: Bjørn Mork, Johan Hovold, Teemu Likonen, linux-usb,
	Dan Williams, stable

On Mon, Jun 12, 2017 at 06:02:16PM +0700, Lars Melin wrote:
> On 2017-06-12 17:37, Bjï¿½rn Mork wrote:
> > Lars Melin <larsm17@gmail.com> writes:
> > 
> >> 1c9e:9803 can be added, the other ones may be reserved id's for
> >> products that never reached the market.
> > 
> > Out of curiosity: How do you know these things?
> > 
> > Thanks for very valuable information.  Our lists of supported devices
> > are long enough without lots of dead entries...

> The driver is almost 6 years old and only the first two id's has 
> surfaced on the net or in all the GPL code I have from some of the major 
> Chinese 3G router manufacturers.
> 1c9e:9801 is btw included in a mfgr specific qmi_wwan driver together
> with some other id's which may interest you.
> Tell me if you want to get that driver and I'll mail it to you.
> 
> The driver is written by Qualcomm for Longcheer and Qualcomm is known 
> for including device id's that either never become used or (even worser) 
> will be used for a product with an interface layout not matching what 
> was listed in the big Qualcomm driver .inf file
> 
> I have never seen qcwwan.ndi used for anything else than rmnet/qmiwwan 
> and a single interface without altsetting and with 3 interfaces whereof 
> one is of interrupt type and with interface attributes ff/ff/ff can't 
> possibly be for any other net type protocol.

Thanks for the details.

So I'll only add these two ids while blacklisting interface 3 and 4
respectively.

Thanks,
Johan

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12  9:16 [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id Johan Hovold
  2017-06-12  9:50 ` Bjørn Mork
@ 2017-06-12 10:11 ` Teemu Likonen
  2017-06-12 10:16   ` Johan Hovold
  1 sibling, 1 reply; 11+ messages in thread
From: Teemu Likonen @ 2017-06-12 10:11 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb, Dan Williams, Bjørn Mork, stable

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

Johan Hovold [2017-06-12 11:16:12+02] wrote:

> Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
> Longcheer vendor id.
>
> Reported-by: Teemu Likonen <tlikonen@iki.fi>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/option.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> Teemu, would you be able to test this patch?

It seems that you will do another patch but I'll confirm anyway that
this works. I compiled the mainline kernel v4.12-rc5 with this patch.

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 3bf61acfc26b..b48f3557b2e4 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
>  /* SpeedUp SU9800 usb 3g modem */
>  #define SPEEDUP_PRODUCT_SU9800			0x9800
>  
> +/* Telewell */
> +#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
> +
>  /* Haier products */
>  #define HAIER_VENDOR_ID				0x201e
>  #define HAIER_PRODUCT_CE81B			0x10f8
> @@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
>  	},
>  	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
> +	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
>  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
>  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
>  	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id
  2017-06-12 10:11 ` Teemu Likonen
@ 2017-06-12 10:16   ` Johan Hovold
  0 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2017-06-12 10:16 UTC (permalink / raw)
  To: Teemu Likonen
  Cc: Johan Hovold, linux-usb, Dan Williams, Bjørn Mork, stable

On Mon, Jun 12, 2017 at 01:11:18PM +0300, Teemu Likonen wrote:
> Johan Hovold [2017-06-12 11:16:12+02] wrote:
> 
> > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
> > Longcheer vendor id.
> >
> > Reported-by: Teemu Likonen <tlikonen@iki.fi>
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/usb/serial/option.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > Teemu, would you be able to test this patch?
> 
> It seems that you will do another patch but I'll confirm anyway that
> this works. I compiled the mainline kernel v4.12-rc5 with this patch.

Great, thanks for testing. It may be you are able to use the QMI driver
for this one as well and we should at least blacklist interface 3.

Thanks,
Johan

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-06-12 14:29 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12  9:16 [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id Johan Hovold
2017-06-12  9:50 ` Bjørn Mork
2017-06-12 10:09   ` Oliver Neukum
2017-06-12 10:12   ` Johan Hovold
2017-06-12 10:14   ` Johan Hovold
2017-06-12 10:31   ` Lars Melin
2017-06-12 10:37     ` Bjørn Mork
2017-06-12 11:02       ` Lars Melin
2017-06-12 14:29         ` Johan Hovold
2017-06-12 10:11 ` Teemu Likonen
2017-06-12 10:16   ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).