From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Shilovskiy <pshilov@microsoft.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Sachin Prabhu <sprabhu@redhat.com>,
Steve French <smfrench@gmail.com>,
Pavel Shilovsky <piastryyy@gmail.com>
Subject: Re: [PATCH] Call echo service immediately after socket reconnect
Date: Mon, 12 Jun 2017 21:16:15 +0200 [thread overview]
Message-ID: <20170612191615.GA2114@kroah.com> (raw)
In-Reply-To: <CY4PR21MB01355B9C697BFB00FDDA20CBB6CD0@CY4PR21MB0135.namprd21.prod.outlook.com>
On Mon, Jun 12, 2017 at 07:08:51PM +0000, Pavel Shilovskiy wrote:
> 2017-06-12 5:30 GMT-07:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Mon, Jun 05, 2017 at 12:15:21PM -0700, Pavel Shilovsky wrote:
> >> From: Sachin Prabhu <sprabhu@redhat.com>
> >>
> >> Commit b8c600120fc8 ("Call echo service immediately after socket
> >> reconnect") upstream.
> >>
> >> Commit 4fcd1813e640 ("Fix reconnect to not defer smb3 session reconnect
> >> long after socket reconnect") changes the behaviour of the SMB2 echo
> >> service and causes it to renegotiate after a socket reconnect. However
> >> under default settings, the echo service could take up to 120 seconds to
> >> be scheduled.
> >>
> >> The patch forces the echo service to be called immediately resulting a
> >> negotiate call being made immediately on reconnect.
> >>
> >> Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
> >> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
> >> Signed-off-by: Steve French <smfrench@gmail.com>
> >> Acked-by: Sachin Prabhu <sprabhu@redhat.com>
> >> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
> >> ---
> >> fs/cifs/connect.c | 24 ++++++++++++++++++------
> >> 1 file changed, 18 insertions(+), 6 deletions(-)
> >
> > What stable tree(s) do you want this applied to? Please be specific
> > like the documentation tells you to do :)
> >
> > And CIFS maintainers, come on, your subject lines for patches suck,
> > please use a prefix like _everyone_ else does to make it more obvious
> > what part of the kernel is being touched.
>
> This patch is targeted for kernels below v4.9, in particular - for
> v4.4 and v3.18 stable kernels. Do you want me to re-send the patch to
> comply with the documentation?
Please do.
next prev parent reply other threads:[~2017-06-12 19:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 19:15 [PATCH] Call echo service immediately after socket reconnect Pavel Shilovsky
2017-06-12 12:30 ` Greg KH
2017-06-12 19:08 ` Pavel Shilovskiy
2017-06-12 19:16 ` Greg KH [this message]
2017-06-12 19:44 ` Pavel Shilovskiy
-- strict thread matches above, loose matches on Subject: below --
2017-05-25 16:46 Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612191615.GA2114@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=piastryyy@gmail.com \
--cc=pshilov@microsoft.com \
--cc=smfrench@gmail.com \
--cc=sprabhu@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox