From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:51532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020AbdFSBL0 (ORCPT ); Sun, 18 Jun 2017 21:11:26 -0400 Date: Mon, 19 Jun 2017 09:11:17 +0800 From: Greg KH To: Jarkko Sakkinen Cc: stable@vger.kernel.org, honclo@linux.vnet.ibm.com Subject: Re: [PATCH] vTPM: Fix missing NULL check Message-ID: <20170619011117.GA2657@kroah.com> References: <20170618234321.21846-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170618234321.21846-1-jarkko.sakkinen@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jun 19, 2017 at 01:43:21AM +0200, Jarkko Sakkinen wrote: > From: "Hon Ching \\(Vicky\\) Lo" > > The current code passes the address of tpm_chip as the argument to > dev_get_drvdata() without prior NULL check in > tpm_ibmvtpm_get_desired_dma. This resulted an oops during kernel > boot when vTPM is enabled in Power partition configured in active > memory sharing mode. > > The vio_driver's get_desired_dma() is called before the probe(), which > for vtpm is tpm_ibmvtpm_probe, and it's this latter function that > initializes the driver and set data. Attempting to get data before > the probe() caused the problem. > > This patch adds a NULL check to the tpm_ibmvtpm_get_desired_dma. > > fixes: 9e0d39d8a6a0 ("tpm: Remove useless priv field in struct tpm_vendor_specific") > Cc: > Signed-off-by: Hon Ching(Vicky) Lo > Reviewed-by: Jarkko Sakkine > Signed-off-by: Jarkko Sakkinen > --- > Backport for v4.9. I asked to Vicky to test my backport so this should be OK. Thanks for this, but next time can you give me a hint of what the git commit id is for the patch in Linus's tree? I had to go dig it out by hand :( greg k-h