Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

Ben Hutchings
2017-06-22T14:15:42Z

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote:
> Hi,
>
> On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote:
> > Just a side note, but i think its worth mentioning to also have
> > look at
> > these fixup patches:
> >
> >
> > -- mm: fix new crash in unmapped_area_topdown()
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> > commit/?id=f4cb767d76cf7ee72f97dd76f6cfa6c76a5edc89
>
> As I mentionned in another mail (this thread starts to be huge), this
> one seems to have already been included in Ben's backport.

That code was completely replaced due to the lack of an rbtree for gaps
in 3.2, so the fix was not needed.

> > -- Allow stack to grow up to address space limit
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> > commit/?id=bd726c90b6b8ce87602208701b208a208e6d5600
>
> This one cleanly applies after, but I think Ben is currently looking
> for feedback on the validity of his backport which was a difficult
> task.

Right.

Ben.

--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]