Re: [PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO

Coly Li
2017-07-01T17:26:30Z

On 2017/7/1 上午4:42, bcache@lists.ewheeler.net wrote:
> From: Tang Junhui <tang.junhui@zte.com.cn>
>
> Since bypassed IOs use no bucket, so do not subtract sectors_to_gc to
> trigger gc thread.
>
> Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
> Reviewed-by: Eric Wheeler <bcache@linux.ewheeler.net>
> Cc: stable@vger.kernel.org

Acked-by: Coly Li <colyli@suse.de>

Thanks.

> ---
> drivers/md/bcache/request.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 958072a..4b413db 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -196,12 +196,12 @@ static void bch_data_insert_start(struct closure *cl)
> struct data_insert_op *op = container_of(cl, struct data_insert_op, cl);
> struct bio *bio = op->bio, *n;
>
> - if (atomic_sub_return(bio_sectors(bio), &op->c->sectors_to_gc) < 0)
> - wake_up_gc(op->c);
> -
> if (op->bypass)
> return bch_data_invalidate(cl);
>
> + if (atomic_sub_return(bio_sectors(bio), &op->c->sectors_to_gc) < 0)
> + wake_up_gc(op->c);
> +
> /*
> * Journal writes are marked REQ_PREFLUSH; if the original write was a
> * flush, it'll wait on the journal write.
>

--
Coly Li