From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60884 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbdGLGG3 (ORCPT ); Wed, 12 Jul 2017 02:06:29 -0400 Date: Wed, 12 Jul 2017 08:06:24 +0200 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, Teddy Wang , stable@vger.kernel.org Subject: Re: [PATCH RESEND] staging: sm750fb: avoid conflicting vesafb Message-ID: <20170712060624.GA11450@kroah.com> References: <1498856263-4544-1-git-send-email-sudipm.mukherjee@gmail.com> <20170711210301.GA4515@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711210301.GA4515@sudip-laptop> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Jul 11, 2017 at 10:03:01PM +0100, Sudip Mukherjee wrote: > Hi Greg, > > On Fri, Jun 30, 2017 at 09:57:43PM +0100, Sudip Mukherjee wrote: > > From: Teddy Wang > > > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > > effectively work with xorg. > > So if it has been alloted fb1, then try to remove the other fb0. > > > > Cc: # v4.4+ > > Signed-off-by: Teddy Wang > > Signed-off-by: Sudip Mukherjee > > --- > > > > In the previous send, why #ifdef is used was asked. > > https://lkml.org/lkml/2017/6/25/57 > > > > Answered at: https://lkml.org/lkml/2017/6/25/69 > > Also pasting here for reference. > > > > 'Did a quick research into "why". > > The patch d8801e4df91e ("x86/PCI: Set IORESOURCE_ROM_SHADOW only for the > > default VGA device") has started setting IORESOURCE_ROM_SHADOW in flags > > for a default VGA device and that is being done only for x86. > > And so, we will need that #ifdef to check IORESOURCE_ROM_SHADOW as that > > needs to be checked only for a x86 and not for other arch.' > > A gentle ping. It's in the middle of the merge window, I can't do anything with patches right now, you know better than this... I'll get to it after 4.13-rc1 is out, relax please. greg k-h