From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen-blkfront: Fix handling of non-supported operations
Date: Mon, 24 Jul 2017 14:20:23 -0700 [thread overview]
Message-ID: <20170724212023.GA2185@vader> (raw)
In-Reply-To: <1500909007.2604.3.camel@wdc.com>
On Mon, Jul 24, 2017 at 03:10:09PM +0000, Bart Van Assche wrote:
> On Mon, 2017-07-24 at 08:46 -0600, Jens Axboe wrote:
> > On 07/21/2017 11:11 AM, Bart Van Assche wrote:
> > > This patch fixes the following sparse warnings:
> > >
> > > drivers/block/xen-blkfront.c:916:45: warning: incorrect type in argument 2 (different base types)
> > > drivers/block/xen-blkfront.c:916:45: expected restricted blk_status_t [usertype] error
> > > drivers/block/xen-blkfront.c:916:45: got int [signed] error
> > > drivers/block/xen-blkfront.c:1599:47: warning: incorrect type in assignment (different base types)
> > > drivers/block/xen-blkfront.c:1599:47: expected int [signed] error
> > > drivers/block/xen-blkfront.c:1599:47: got restricted blk_status_t [usertype] <noident>
> > > drivers/block/xen-blkfront.c:1607:55: warning: incorrect type in assignment (different base types)
> > > drivers/block/xen-blkfront.c:1607:55: expected int [signed] error
> > > drivers/block/xen-blkfront.c:1607:55: got restricted blk_status_t [usertype] <noident>
> > > drivers/block/xen-blkfront.c:1625:55: warning: incorrect type in assignment (different base types)
> > > drivers/block/xen-blkfront.c:1625:55: expected int [signed] error
> > > drivers/block/xen-blkfront.c:1625:55: got restricted blk_status_t [usertype] <noident>
> > > drivers/block/xen-blkfront.c:1628:62: warning: restricted blk_status_t degrades to integer
> > >
> > > Compile-tested only.
> >
> > Applied, but I killed your stable tag. Why did you add that?
>
> Hello Jens,
>
> That tag was added based on the output of git describe:
> $ git describe 2a842acab109
> v4.12-rc2-199-g2a842acab109
>
> However, the following command shows that the above output is misleading and that the
> stable tag is indeed not needed:
> $ git log v4.12..origin/master | grep '^commit 2a842acab109'
> commit 2a842acab109f40f0d7d10b38e9ca88390628996
>
> Bart.
You want git tag --contains:
$ git tag --contains 2a842acab109
v4.13-rc1
v4.13-rc2
prev parent reply other threads:[~2017-07-24 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 17:11 [PATCH] xen-blkfront: Fix handling of non-supported operations Bart Van Assche
2017-07-24 8:02 ` Christoph Hellwig
2017-07-24 14:46 ` Jens Axboe
2017-07-24 15:10 ` Bart Van Assche
2017-07-24 21:20 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724212023.GA2185@vader \
--to=osandov@osandov.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).