From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33424 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbdGYOsn (ORCPT ); Tue, 25 Jul 2017 10:48:43 -0400 Date: Tue, 25 Jul 2017 07:48:37 -0700 From: Greg KH To: Chris Metcalf Cc: dwoods@mellanox.com, jh80.chung@samsung.com, ulf.hansson@linaro.org, stable@vger.kernel.org Subject: Re: WTF: patch "[PATCH] mmc: dw_mmc: Use device_property_read instead of" was seriously submitted to be applied to the 4.12-stable tree? Message-ID: <20170725144837.GC1618@kroah.com> References: <150093913718756@kroah.com> <1f17f58c-9b54-58b1-9717-4a50a29799c0@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f17f58c-9b54-58b1-9717-4a50a29799c0@mellanox.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jul 24, 2017 at 09:22:44PM -0400, Chris Metcalf wrote: > On 7/24/2017 7:32 PM, gregkh@linuxfoundation.org wrote: > > The patch below was submitted to be applied to the 4.12-stable tree. > > > > I fail to see how this patch meets the stable kernel rules as found at > > Documentation/process/stable_kernel_rules.rst. > > > > [...] > > > > Using the device_property interfaces allows the dw_mmc driver to work > > on platforms which run on either device tree or ACPI. > > > > Signed-off-by: David Woods > > Reviewed-by: Chris Metcalf > > Cc: stable@vger.linux.org > > Acked-by: Jaehoon Chung > > Signed-off-by: Ulf Hansson > > I encouraged Dave to cc stable, so this is on me if it was a bad call. > > This bug is the only thing blocking our ARM64 hardware (Mellanox > BlueField, google if curious) from booting up with RedHat 7 on our > standard hardware config with an eMMC rootfs. RedHat 7 requires > ACPI for server configuration builds, and the eMMC drivers didn't > support ACPI, just device tree, so the chip couldn't boot. > > The two changes are obviously correct (mechanical substitution > of "of_*" to "device_*"), short, and fix a clear bug in booting up RHEL. > Now obviously we are working with RedHat directly to get them to > include the fix (RH bugzilla 1466917) but it seemed plausible to > push the fix upstream so it would get picked up elsewhere as well and > enable booting older mainstream ARM64 kernels on our hardware. So is this the _only_ change that is needed to get a 4.9 and/or a 4.12 kernel running on your hardware? Or would they need other ones as well? thanks, greg k-h