From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: avoid conflicting vesafb
Date: Sun, 30 Jul 2017 08:37:28 -0700 [thread overview]
Message-ID: <20170730153728.GA9989@kroah.com> (raw)
In-Reply-To: <1501363063-4261-1-git-send-email-sudipm.mukherjee@gmail.com>
On Sat, Jul 29, 2017 at 10:17:43PM +0100, Sudip Mukherjee wrote:
> From: Teddy Wang <teddy.wang@siliconmotion.com>
>
> commit 740c433ec35187b45abe08bb6c45a321a791be8e upstream
>
> If vesafb is enabled in the config then /dev/fb0 is created by vesa
> and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
> effectively work with xorg.
> So if it has been alloted fb1, then try to remove the other fb0.
>
> In the previous send, why #ifdef is used was asked.
> https://lkml.org/lkml/2017/6/25/57
>
> Answered at: https://lkml.org/lkml/2017/6/25/69
> Also pasting here for reference.
>
> 'Did a quick research into "why".
> The patch d8801e4df91e ("x86/PCI: Set IORESOURCE_ROM_SHADOW only for the
> default VGA device") has started setting IORESOURCE_ROM_SHADOW in flags
> for a default VGA device and that is being done only for x86.
> And so, we will need that #ifdef to check IORESOURCE_ROM_SHADOW as that
> needs to be checked only for a x86 and not for other arch.'
>
> Cc: <stable@vger.kernel.org> # v4.4
> Signed-off-by: Teddy Wang <teddy.wang@siliconmotion.com>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/sm750fb/sm750.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
Still does not apply to my staging-linus branch without manual fixups.
What is going on here? Please fix up and resend properly...
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-30 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 21:17 [PATCH] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee
2017-07-30 15:37 ` Greg Kroah-Hartman [this message]
2017-08-04 21:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170730153728.GA9989@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).