From: Greg KH <greg@kroah.com>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: stable@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: tmio-mmc: fix bad pointer math
Date: Tue, 1 Aug 2017 14:03:37 -0700 [thread overview]
Message-ID: <20170801210337.GA9762@kroah.com> (raw)
In-Reply-To: <20170801204334.106262-1-chris.brandt@renesas.com>
On Tue, Aug 01, 2017 at 03:43:34PM -0500, Chris Brandt wrote:
> commit 9c284c41c0886f09e75c323a16278b6d353b0b4a upstream.
>
> The existing code gives an incorrect pointer value.
> The buffer pointer 'buf' was of type unsigned short *, and 'count' was a
> number in bytes. A cast of buf should have been used.
>
> However, instead of casting, just change the code to use u32 pointers.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 8185e51f358a: ("mmc: tmio-mmc: add support for 32bit data port")
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/host/tmio_mmc_pio.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
What kernel tree(s) is this for?
thanks,
greg k-h
next prev parent reply other threads:[~2017-08-01 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:43 [PATCH] mmc: tmio-mmc: fix bad pointer math Chris Brandt
2017-08-01 21:03 ` Greg KH [this message]
2017-08-02 12:08 ` Chris Brandt
2017-08-02 13:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801210337.GA9762@kroah.com \
--to=greg@kroah.com \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).