From: Kalle Valo <kvalo@codeaurora.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
Malcolm Priestley <tvboxspy@gmail.com>,
stable@vger.kernel.org
Subject: Re: [BUG] rtlwifi: rtl_pci_probe: Fix fail path of _rtl_pci_find_adapter
Date: Thu, 3 Aug 2017 09:34:12 +0000 (UTC) [thread overview]
Message-ID: <20170803093412.AE5BB60224@smtp.codeaurora.org> (raw)
In-Reply-To: <20170730080219.5925-1-tvboxspy@gmail.com>
Malcolm Priestley <tvboxspy@gmail.com> wrote:
> _rtl_pci_find_adapter fail path will jump to label fail3 for
> unsupported adapter types.
>
> However, on course for fail3 there will be call rtl_deinit_core
> before rtl_init_core.
>
> For the inclusion of checking pci_iounmap this fail can be moved to
> fail2.
>
> Fixes
> [ 4.492963] BUG: unable to handle kernel NULL pointer dereference at (null)
> [ 4.493067] IP: rtl_deinit_core+0x31/0x90 [rtlwifi]
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> Cc: <stable@vger.kernel.org>
Patch applied to wireless-drivers-next.git, thanks.
fc81bab5eeb1 rtlwifi: rtl_pci_probe: Fix fail path of _rtl_pci_find_adapter
--
https://patchwork.kernel.org/patch/9870227/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-08-03 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 8:02 [PATCH][BUG] rtlwifi: rtl_pci_probe: Fix fail path of _rtl_pci_find_adapter Malcolm Priestley
2017-08-03 9:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803093412.AE5BB60224@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).