From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Abhishek Sahu <absahu@codeaurora.org>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, richard@nod.at,
cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
architt@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-mtd@lists.infradead.org, andy.gross@linaro.org,
sricharan@codeaurora.org
Subject: Re: [PATCH v2 01/25] mtd: nand: qcom: fix config error for BCH
Date: Thu, 3 Aug 2017 20:47:26 +0200 [thread overview]
Message-ID: <20170803204726.74f75aaa@bbrezillon> (raw)
In-Reply-To: <a48aafe1d5d0623f2cc7cd5c29fc1410@codeaurora.org>
On Thu, 03 Aug 2017 23:22:37 +0530
Abhishek Sahu <absahu@codeaurora.org> wrote:
> On 2017-08-03 21:26, Boris Brezillon wrote:
> > On Wed, 19 Jul 2017 17:17:49 +0530
> > Abhishek Sahu <absahu@codeaurora.org> wrote:
> >
> >> The configuration for BCH is not correct in the current driver.
> >> The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the
> >> BCH ECC in which
> >>
> >> 0x1 : BCH_DISABLED
> >> 0x0 : BCH_ENABLED
> >>
> >> But currently host->bch_enabled is being assined to BCH_DISABLED.
> >>
> >> Fixes: c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> >> ---
> >> drivers/mtd/nand/qcom_nandc.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/qcom_nandc.c
> >> b/drivers/mtd/nand/qcom_nandc.c
> >> index 57d483a..bc0408c 100644
> >> --- a/drivers/mtd/nand/qcom_nandc.c
> >> +++ b/drivers/mtd/nand/qcom_nandc.c
> >> @@ -1,5 +1,5 @@
> >> /*
> >> - * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> >> + * Copyright (c) 2016-2017, The Linux Foundation. All rights
> >> reserved.
> >
> > Hm, this copyright update is not really related to the changes you're
> > describing in the commit message. I'll drop this line from the commit
> > (no need to resend it) and ask you to send a separate patch updating
> > the
> > copyright. Is that ok?
> >
>
> The idea was to change the copyright year since we are making
> the changes in this file. If it requires separate patch, then I
> will do the same.
Yes, I'd prefer a separate patch.
>
> Also I need to change 'assined' -> assigned in commit text.
Yep, already fixed that one.
> I can
> update the patch and fix this. I am planning to send the v3 patches
> tomorrow which incorporates all the review comments.
Can you wait a bit. I already applied some of your patches [1] and would
like to finish my review.
Thanks,
Boris
[1]https://github.com/bbrezillon/linux-0day/commits/nand/next
next prev parent reply other threads:[~2017-08-03 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1500464893-11352-1-git-send-email-absahu@codeaurora.org>
2017-07-19 11:47 ` [PATCH v2 01/25] mtd: nand: qcom: fix config error for BCH Abhishek Sahu
2017-08-02 5:47 ` Archit Taneja
2017-08-03 15:56 ` Boris Brezillon
2017-08-03 17:52 ` Abhishek Sahu
2017-08-03 18:47 ` Boris Brezillon [this message]
2017-08-03 19:02 ` Abhishek Sahu
2017-08-04 7:46 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803204726.74f75aaa@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).