From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:59532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbdHCWfe (ORCPT ); Thu, 3 Aug 2017 18:35:34 -0400 Date: Thu, 3 Aug 2017 15:35:33 -0700 From: Greg KH To: Sudeep Holla Cc: stable@vger.kernel.org, rafael.j.wysocki@intel.com, ulf.hansson@linaro.org Subject: Re: [PATCH v4.4 STABLE] PM / Domains: defer setting dev->pm_domain until genpd->attach_dev succeeds if present Message-ID: <20170803223533.GE2396@kroah.com> References: <1501005276213126@kroah.com> <1501063655-30208-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501063655-30208-1-git-send-email-sudeep.holla@arm.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jul 26, 2017 at 11:07:35AM +0100, Sudeep Holla wrote: > commit 975e83cfb8dc16e7a2fdc58188c77c0c605876c2 upstream. > > If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach > may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets > the PM domain for the device unconditionally. > > When subsequent attempts are made to call genpd_dev_pm_attach, it may > return -EEXISTS checking dev->pm_domain without re-attempting to call > attach_dev or power_on. > > platform_drv_probe then attempts to call drv->probe as the return value > -EEXIST != -EPROBE_DEFER, which may end up in a situation where the > device is accessed without it's power domain switched on. > > Fixes: f104e1e5ef57 (PM / Domains: Re-order initialization of generic_pm_domain_data) > Cc: 4.4+ # v4.4+ > Signed-off-by: Sudeep Holla > Acked-by: Ulf Hansson > Signed-off-by: Rafael J. Wysocki > --- > drivers/base/power/domain.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Now applied, thanks. greg k-h