From: Greg KH <greg@kroah.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: stable@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
Dariusz Dokupil <dariusz.dokupil@intel.com>,
linux-nvdimm@lists.01.org
Subject: Re: [4.9-stable PATCH] device-dax: fix sysfs duplicate warnings
Date: Fri, 4 Aug 2017 13:01:44 -0700 [thread overview]
Message-ID: <20170804200144.GH3477@kroah.com> (raw)
In-Reply-To: <150180630236.6719.1152880381080551797.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Aug 03, 2017 at 05:25:02PM -0700, Dan Williams wrote:
> commit bbb3be170ac2891526ad07b18af7db226879a8e7 upstream.
>
> Fix warnings of the form...
>
> WARNING: CPU: 10 PID: 4983 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80
> sysfs: cannot create duplicate filename '/class/dax/dax12.0'
> Call Trace:
> dump_stack+0x63/0x86
> __warn+0xcb/0xf0
> warn_slowpath_fmt+0x5a/0x80
> ? kernfs_path_from_node+0x4f/0x60
> sysfs_warn_dup+0x62/0x80
> sysfs_do_create_link_sd.isra.2+0x97/0xb0
> sysfs_create_link+0x25/0x40
> device_add+0x266/0x630
> devm_create_dax_dev+0x2cf/0x340 [dax]
> dax_pmem_probe+0x1f5/0x26e [dax_pmem]
> nvdimm_bus_probe+0x71/0x120
>
> ...by reusing the namespace id for the device-dax instance name.
>
> Now that we have decided that there will never by more than one
> device-dax instance per libnvdimm-namespace parent device [1], we can
> directly reuse the namepace ids. There are some possible follow-on
> cleanups, but those are saved for a later patch to simplify the -stable
> backport.
>
> [1]: https://lists.01.org/pipermail/linux-nvdimm/2016-December/008266.html
>
> Fixes: 98a29c39dc68 ("libnvdimm, namespace: allow creation of multiple pmem...")
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: <stable@vger.kernel.org>
> Reported-by: Dariusz Dokupil <dariusz.dokupil@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/dax/dax.c | 24 ++++++++++++++++--------
> drivers/dax/dax.h | 2 +-
> drivers/dax/pmem.c | 12 +++++++-----
> 3 files changed, 24 insertions(+), 14 deletions(-)
Thanks for the backport, now applied.
greg k-h
prev parent reply other threads:[~2017-08-04 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 17:53 FAILED: patch "[PATCH] device-dax: fix sysfs duplicate warnings" failed to apply to 4.9-stable tree gregkh
2017-08-04 0:25 ` [4.9-stable PATCH] device-dax: fix sysfs duplicate warnings Dan Williams
2017-08-04 20:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804200144.GH3477@kroah.com \
--to=greg@kroah.com \
--cc=dan.j.williams@intel.com \
--cc=dariusz.dokupil@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).