From: Christoph Hellwig <hch@lst.de>
To: Johan Hovold <johan@kernel.org>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andreas Färber" <afaerber@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Alan Stern" <stern@rowland.harvard.edu>,
stable <stable@vger.kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Sricharan R" <sricharan@codeaurora.org>,
"Stefan Wahren" <stefan.wahren@i2se.com>
Subject: Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe
Date: Sat, 5 Aug 2017 10:38:07 +0200 [thread overview]
Message-ID: <20170805083807.GB14144@lst.de> (raw)
In-Reply-To: <20170803155208.22165-1-johan@kernel.org>
I think the root problem is that the code added by
" of/acpi: Configure dma operations at probe time for platform/amba/pci bus
devices"
is completely bogus and needs to be reverted. We can't simply iterate
over all devices in the system and set up dma for them. We'll need
to ask the firmware / OF what root port this applies to and only
apply it to those buses.
Note that the current code checks for a OF or ACPI node already,
so we should start by refining these checks.
next prev parent reply other threads:[~2017-08-05 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 15:52 [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe Johan Hovold
2017-08-03 16:07 ` Greg Kroah-Hartman
2017-08-03 16:23 ` Johan Hovold
2017-08-05 8:38 ` Christoph Hellwig [this message]
2017-08-08 18:03 ` Johan Hovold
2017-08-11 6:02 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170805083807.GB14144@lst.de \
--to=hch@lst.de \
--cc=afaerber@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sricharan@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).