From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:33472 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144AbdHEIiJ (ORCPT ); Sat, 5 Aug 2017 04:38:09 -0400 Date: Sat, 5 Aug 2017 10:38:07 +0200 From: Christoph Hellwig To: Johan Hovold Cc: Christoph Hellwig , Marek Szyprowski , Greg Kroah-Hartman , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Stern , stable , Robin Murphy , Sricharan R , Stefan Wahren Subject: Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe Message-ID: <20170805083807.GB14144@lst.de> References: <20170803155208.22165-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170803155208.22165-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: I think the root problem is that the code added by " of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices" is completely bogus and needs to be reverted. We can't simply iterate over all devices in the system and set up dma for them. We'll need to ask the firmware / OF what root port this applies to and only apply it to those buses. Note that the current code checks for a OF or ACPI node already, so we should start by refining these checks.