From: Johannes Thumshirn <jthumshirn@suse.de>
To: Chris Clayton <chris2553@googlemail.com>,
gregkh@linuxfoundation.org,
James Bottomley <jejb@linux.vnet.ibm.com>
Cc: gregkh@linuxfoundation.org, dgilbert@interlog.com, hare@suse.com,
martin.petersen@oracle.com, stable@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: Patch "scsi: sg: fix SG_DXFER_FROM_DEV transfers" has been added to the 4.12-stable tree
Date: Tue, 8 Aug 2017 14:20:22 +0200 [thread overview]
Message-ID: <20170808121935.GH3926@linux-x5ow.site> (raw)
In-Reply-To: <7f2007f7-1952-782e-b694-ed07b57008bb@googlemail.com>
On Tue, Aug 08, 2017 at 12:42:17PM +0100, Chris Clayton wrote:
> On 07/08/17 21:32, gregkh@linuxfoundation.org wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > scsi: sg: fix SG_DXFER_FROM_DEV transfers
> >
> > to the 4.12-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > scsi-sg-fix-sg_dxfer_from_dev-transfers.patch
> > and it can be found in the queue-4.12 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> >
>
> Johannes' commit message says that the transfer must have a length bigger than 0, so the code should return false if the
> length is less than or equal to 0, but the test is for less than 0.
>
> But in any case, there's another patch that removes all this sg_is_valid_dxfer() jiggery-pokery and replaces it with a
> simpler test. It hasn't reached Linus' tree yet but is, I believe, cc'd to stable.
Yup, I hope James is sending it out for this weekend's -rc and then it should
be backported to stable instead.
James any plans in doing otherwise?
Greg is this acceptible for you?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-08-08 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 20:32 Patch "scsi: sg: fix SG_DXFER_FROM_DEV transfers" has been added to the 4.12-stable tree gregkh
2017-08-08 11:42 ` Chris Clayton
2017-08-08 12:20 ` Johannes Thumshirn [this message]
2017-08-08 14:39 ` James Bottomley
2017-08-09 6:32 ` Johannes Thumshirn
2017-08-08 16:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808121935.GH3926@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=chris2553@googlemail.com \
--cc=dgilbert@interlog.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).