From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:47540 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751880AbdHHMU3 (ORCPT ); Tue, 8 Aug 2017 08:20:29 -0400 Date: Tue, 8 Aug 2017 14:20:22 +0200 From: Johannes Thumshirn To: Chris Clayton , gregkh@linuxfoundation.org, James Bottomley Cc: gregkh@linuxfoundation.org, dgilbert@interlog.com, hare@suse.com, martin.petersen@oracle.com, stable@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "scsi: sg: fix SG_DXFER_FROM_DEV transfers" has been added to the 4.12-stable tree Message-ID: <20170808121935.GH3926@linux-x5ow.site> References: <1502137958231142@kroah.com> <7f2007f7-1952-782e-b694-ed07b57008bb@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7f2007f7-1952-782e-b694-ed07b57008bb@googlemail.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Aug 08, 2017 at 12:42:17PM +0100, Chris Clayton wrote: > On 07/08/17 21:32, gregkh@linuxfoundation.org wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > scsi: sg: fix SG_DXFER_FROM_DEV transfers > > > > to the 4.12-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > scsi-sg-fix-sg_dxfer_from_dev-transfers.patch > > and it can be found in the queue-4.12 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let know about it. > > > > Johannes' commit message says that the transfer must have a length bigger than 0, so the code should return false if the > length is less than or equal to 0, but the test is for less than 0. > > But in any case, there's another patch that removes all this sg_is_valid_dxfer() jiggery-pokery and replaces it with a > simpler test. It hasn't reached Linus' tree yet but is, I believe, cc'd to stable. Yup, I hope James is sending it out for this weekend's -rc and then it should be backported to stable instead. James any plans in doing otherwise? Greg is this acceptible for you? Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850