From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46305 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbdHIX6a (ORCPT ); Wed, 9 Aug 2017 19:58:30 -0400 Date: Wed, 9 Aug 2017 16:58:26 -0700 From: Greg KH To: Holger =?iso-8859-1?Q?Hoffst=E4tte?= Cc: stable@vger.kernel.org Subject: Re: [PATCH 4.9 00/93] 4.9.42-stable review Message-ID: <20170809235826.GA9412@kroah.com> References: <20170809181335.658857427@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, Aug 09, 2017 at 11:33:30PM +0000, Holger Hoffst�tte wrote: > On Wed, 09 Aug 2017 11:12:53 -0700, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.9.42 release. > > There are 93 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > The patch "workqueue-restore-wq_unbound-max_active-1-to-be-ordered.patch" > creates a regression because some workqueue users diddle with > workqueue_set_max_active(), which results in endless WARNING spam - > in my case during btrfs metadata operations: > > Aug 10 00:23:50 tux kernel: WARNING: CPU: 3 PID: 29080 at kernel/workqueue.c:4116 workqueue_set_max_active+0x89/0x90 > Aug 10 00:23:50 tux kernel: Modules linked in: nfsd auth_rpcgss oid_registry lockd grace sunrpc sch_fq_codel btrfs xor raid6_pq xfs x86_pkg_temp_thermal crc32_pclmul crc32c_intel snd_hda_codec_hdmi nct6775 hwmon_vid coretemp aesni_intel aes_x86_64 glue_helper snd_hda_codec_realtek lrw gf128mul ablk_helper snd_hda_codec_generic cryptd usbhid r8169 mii i2c_i801 i2c_smbus i2c_core snd_hda_intel snd_hda_codec snd_hda_core snd_pcm snd_timer snd soundcore video > Aug 10 00:23:50 tux kernel: CPU: 3 PID: 29080 Comm: kworker/u8:5 Tainted: G W 4.9.42 #1 > Aug 10 00:23:50 tux kernel: Hardware name: System manufacturer System Product Name/P8Z68-V LX, BIOS 4105 07/01/2013 > Aug 10 00:23:50 tux kernel: Workqueue: btrfs-delayed-meta btrfs_delayed_meta_helper [btrfs] > Aug 10 00:23:50 tux kernel: ffffc90004dfbd38 ffffffff812fce27 0000000000000000 0000000000000000 > Aug 10 00:23:50 tux kernel: ffffc90004dfbd78 ffffffff81056eeb 00001014d17b1000 ffff8807f62daf80 > Aug 10 00:23:50 tux kernel: ffff8807fadf3e00 ffff8807f9d6e100 ffff880599a3a890 0000000000000000 > Aug 10 00:23:50 tux kernel: Call Trace: > Aug 10 00:23:50 tux kernel: [] dump_stack+0x4d/0x66 > Aug 10 00:23:50 tux kernel: [] __warn+0xcb/0xf0 > Aug 10 00:23:50 tux kernel: [] warn_slowpath_null+0x1d/0x20 > Aug 10 00:23:50 tux kernel: [] workqueue_set_max_active+0x89/0x90 > Aug 10 00:23:50 tux kernel: [] btrfs_worker_helper+0x2e9/0x2f0 [btrfs] > Aug 10 00:23:50 tux kernel: [] ? btrfs_worker_helper+0x272/0x2f0 [btrfs] > Aug 10 00:23:50 tux kernel: [] btrfs_delayed_meta_helper+0xe/0x10 [btrfs] > Aug 10 00:23:50 tux kernel: [] process_one_work+0x1dd/0x460 > Aug 10 00:23:50 tux kernel: [] ? try_to_del_timer_sync+0x4b/0x60 > Aug 10 00:23:50 tux kernel: [] worker_thread+0x48/0x4d0 > Aug 10 00:23:50 tux kernel: [] ? process_one_work+0x460/0x460 > Aug 10 00:23:50 tux kernel: [] kthread+0xd7/0xf0 > Aug 10 00:23:50 tux kernel: [] ? kthread_park+0x60/0x60 > Aug 10 00:23:50 tux kernel: [] ret_from_fork+0x22/0x30 > Aug 10 00:23:50 tux kernel: ---[ end trace cc35cf747f3aa89e ]- > > Luckily this can be easily fixed by also applying upstream followup > commit 0a94efb5acbb6 ("workqueue: implicit ordered attribute should be > overridable"), which is marked approppriately as fix, but apparently > wasn't sent to -stable. > > I applied it on top of .42-rc1 and the WARNING spam is gone, so please > add it to the final .42 release as well. Should it also go into all of the other stable trees that this commit is now going into? thanks, greg k-h