* [PATCH 3/7] dm-mpath: Do not lock up a CPU with requeuing activity
[not found] <20170809183216.526-1-bart.vanassche@wdc.com>
@ 2017-08-09 18:32 ` Bart Van Assche
2017-08-10 9:29 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Bart Van Assche @ 2017-08-09 18:32 UTC (permalink / raw)
To: Mike Snitzer
Cc: dm-devel, Christoph Hellwig, Bart Van Assche, Laurence Oberman,
stable
When using the block layer in single queue mode, get_request()
returns ERR_PTR(-EAGAIN) if the queue is dying and the REQ_NOWAIT
flag has been passed to get_request(). Avoid that the kernel
reports soft lockup complaints in this case due to continuous
requeuing activity.
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Laurence Oberman <loberman@redhat.com>
Cc: <stable@vger.kernel.org>
---
drivers/md/dm-mpath.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 0e8ab5bb3575..0baa461eccaa 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -504,7 +504,6 @@ static int multipath_clone_and_map(struct dm_target *ti, struct request *rq,
if (queue_dying) {
atomic_inc(&m->pg_init_in_progress);
activate_or_offline_path(pgpath);
- return DM_MAPIO_REQUEUE;
}
return DM_MAPIO_DELAY_REQUEUE;
}
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/7] dm-mpath: Do not lock up a CPU with requeuing activity
2017-08-09 18:32 ` [PATCH 3/7] dm-mpath: Do not lock up a CPU with requeuing activity Bart Van Assche
@ 2017-08-10 9:29 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-08-10 9:29 UTC (permalink / raw)
To: Bart Van Assche
Cc: Mike Snitzer, dm-devel, Christoph Hellwig, Laurence Oberman,
stable
On Wed, Aug 09, 2017 at 11:32:12AM -0700, Bart Van Assche wrote:
> When using the block layer in single queue mode, get_request()
> returns ERR_PTR(-EAGAIN) if the queue is dying and the REQ_NOWAIT
> flag has been passed to get_request(). Avoid that the kernel
> reports soft lockup complaints in this case due to continuous
> requeuing activity.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-10 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170809183216.526-1-bart.vanassche@wdc.com>
2017-08-09 18:32 ` [PATCH 3/7] dm-mpath: Do not lock up a CPU with requeuing activity Bart Van Assche
2017-08-10 9:29 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).