From: Maksim Salau <maksim.salau@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
akpm@linux-foundation.org,
"Alfredo Rafael Vicente Boix" <alviboi@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack
Date: Sat, 19 Aug 2017 09:29:40 +0300 [thread overview]
Message-ID: <20170819092940.62513d5c@gmail.com> (raw)
In-Reply-To: <lsq.1503062000.990820443@decadent.org.uk>
On Fri, 18 Aug 2017 14:13:20 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:
> 3.16.47-rc1 review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Maksim Salau <maksim.salau@gmail.com>
>
> commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream.
>
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().
Hi Ben,
The change has a memory leak, which is fixed by the commit
0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3
If the commit is not in your queue, please add it.
Thanks,
Maksim.
next prev parent reply other threads:[~2017-08-19 6:29 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 13:13 [PATCH 3.16 000/134] 3.16.47-rc1 review Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 006/134] ath9k_htc: Add new USB ID Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting Ben Hutchings
2017-08-18 13:53 ` Eric Dumazet
2017-08-26 0:33 ` Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 058/134] PCI: Fix another sanity check bug in /proc/pci mmap Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack Ben Hutchings
2017-08-19 6:29 ` Maksim Salau [this message]
2017-08-26 0:37 ` Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 023/134] pinctrl: sh-pfc: r8a7791: Fix IPSR comment typos Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 070/134] NFS: Use GFP_NOIO for two allocations in writeback Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 041/134] serial: omap: fix runtime-pm handling on unbind Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 027/134] IPoIB: Remove unnecessary test for NULL before debugfs_remove() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 074/134] powerpc/pseries: Fix of_node_put() underflow during DLPAR remove Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 118/134] target/fileio: Fix zero-length READ and WRITE handling Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 054/134] [media] digitv: limit messages to buffer size Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 004/134] ima: pass 'opened' flag to identify newly created files Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 087/134] staging: rtl8188eu: prevent an underflow in rtw_check_beacon_data() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 025/134] PCI: dwc: Fix uninitialized variable in dw_handle_msi_irq() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 116/134] of: fix sparse warning in of_pci_range_parser_one Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 049/134] perf/x86: Fix spurious NMI with PEBS Load Latency event Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 030/134] [media] s5p-mfc: Fix unbalanced call to clock management Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 031/134] scsi: scsi_error: count medium access timeout only once per EH run Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 128/134] dentry name snapshots Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 082/134] usb: Make sure usb/phy/of gets built-in Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 088/134] staging: gdm724x: gdm_mux: Remove create_workqueue() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 035/134] [media] cx231xx-cards: fix NULL-deref at probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 053/134] net: ipv6: send unsolicited NA on admin up Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 018/134] USB: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 068/134] mwifiex: pcie: fix cmd_buf use-after-free in remove/reset Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 131/134] mqueue: fix a use-after-free in sys_mq_notify() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 110/134] tg3: don't clear stats while tg3_close Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 061/134] USB: serial: ftdi_sio: add device ID for Microsemi/Arrow SF2PLUS Dev Kit Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 113/134] lockdep: teach lockdep about memalloc_noio_save Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 100/134] ipv6: Need to export ipv6_push_frag_opts for tunneling now Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 079/134] dm era: save spacemap metadata root after the pre-commit Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 009/134] serial: sh-sci: Fix panic when serial console and DMA are enabled Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 080/134] PCI: Disable boot interrupt quirk for ASUS M2N-LR Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 076/134] netfilter: ctnetlink: fix deadlock due to acquire _expect_lock twice Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 016/134] [media] mceusb: fix NULL-deref at probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 090/134] IB/core: If the MGID/MLID pair is not on the list return an error Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 069/134] x86/boot: Fix BSS corruption/overwrite bug in early x86 kernel startup Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 103/134] drm/edid: Add 10 bpc quirk for LGD 764 panel in HP zBook 17 G2 Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 047/134] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 008/134] perf hists browser: Fix typo in function switch_data_file Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 039/134] padata: free correct variable Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 067/134] usb: host: xhci: print correct command ring address Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 029/134] [media] gspca: konica: add missing endpoint sanity check Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 048/134] perf/x86/pebs: Fix handling of PEBS buffer overflows Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 037/134] [media] cx231xx-audio: fix NULL-deref at probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 073/134] IB/mlx4: Fix ib device initialization error flow Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 121/134] x86/mm/32: Set the '__vmalloc_start_set' flag in initmem_init() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 065/134] ath9k: off by one in ath9k_hw_nvram_read_array() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 101/134] dm bufio: avoid a possible ABBA deadlock Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 026/134] ath9k_htc: fix NULL-deref at probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 040/134] perf inject: Don't proceed if perf_session__process_event() fails Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 015/134] [media] serial_ir: iommap is a memory address, not bool Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 066/134] KVM: arm/arm64: fix races in kvm_psci_vcpu_on Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 089/134] staging: gdm724x: gdm_mux: fix use-after-free on module unload Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 125/134] arm64: ensure extension of smp_store_release value Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 107/134] cifs: small underflow in cnvrtDosUnixTm() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 133/134] ipv6: Should use consistent conditional judgement for ip6 fragment between __ip6_append_data and ip6_finish_output Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 127/134] ath9k_htc: add device ID for Toshiba WLM-20U2/GN-1080 Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 007/134] ath9k_htc: Add support of AirTies 1eda:2315 AR9271 device Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 086/134] dm ioctl: prevent stack leak in dm ioctl call Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 062/134] [media] ttusb2: limit messages to buffer size Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 126/134] arm64: uaccess: ensure extension of access_ok() addr Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 102/134] arm64: KVM: Fix decoding of Rt/Rt2 when trapping AArch32 CP accesses Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 097/134] power: supply: pda_power: move from timer to delayed_work Ben Hutchings
2017-08-19 16:05 ` Michael Nazzareno Trimarchi
2017-08-19 19:55 ` Anthony Brandon
2017-08-18 13:13 ` [PATCH 3.16 081/134] fanotify: don't expose EOPENSTALE to userspace Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 042/134] serial: omap: suspend device on probe errors Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 132/134] packet: fix tp_reserve race in packet_set_ring Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 010/134] pinctrl: sh-pfc: Update info pointer after SoC-specific init Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 060/134] PCI: Freeze PME scan before suspending devices Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 036/134] [media] cx231xx-audio: fix init error path Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 001/134] [media] pvrusb2: reduce stack usage pvr2_eeprom_analyze() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 115/134] ceph: fix memory leak in __ceph_setxattr() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 021/134] pinctrl: sh-pfc: r8a7791: Add missing DVC_MUTE signal Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 063/134] [media] dw2102: limit messages to buffer size Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 130/134] timerfd: Protect the might cancel mechanism proper Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 098/134] Input: twl4030-pwrbutton - use correct device for irq request Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 051/134] iio: proximity: as3935: fix as3935_write Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 124/134] net/mlx4_en: Avoid adding steering rules with invalid ring Ben Hutchings
2017-08-20 9:19 ` Tariq Toukan
2017-08-26 1:10 ` Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 033/134] [media] dib0700: fix NULL-deref at probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 034/134] [media] usbvision: " Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 108/134] Set unicode flag on cifs echo request to avoid Mac error Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 129/134] ipv6: avoid overflow of offset in ip6_find_1stfragopt Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 093/134] ext4: evict inline data when writing to memory map Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 096/134] power: supply: isp1704: Fix unchecked return value of devm_kzalloc Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 050/134] iio: dac: ad7303: fix channel description Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 099/134] ip6_tunnel: Fix missing tunnel encapsulation limit option Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 071/134] IB/ipoib: Update broadcast object if PKey value was changed in index 0 Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 095/134] Bluetooth: Fix user channel for 32bit userspace on 64bit kernel Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 024/134] PCI: dwc: Unindent dw_handle_msi_irq() loop Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 111/134] CIFS: fix oplock break deadlocks Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 091/134] IB/core: For multicast functions, verify that LIDs are multicast LIDs Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 059/134] PCI: Only allow WC mmap on prefetchable resources Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 075/134] powerpc/sysfs: Fix reference leak of cpu device_nodes present at boot Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 028/134] IB/IPoIB: ibX: failed to create mcg debug file Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 003/134] staging: comedi: jr3_pci: cope with jiffies wraparound Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 020/134] pinctrl: sh-pfc: r8a7791: Add missing HSCIF1 pinmux data Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 055/134] [media] zr364xx: enforce minimum size when reading header Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 134/134] udp: consistently apply ufo or fragmentation Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 105/134] metag/uaccess: Fix access_ok() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 122/134] virtio_net: fix support for small rings Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 072/134] HSI: ssi_protocol: double free in ssip_pn_xmit() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 057/134] PCI: Ignore write combining when mapping I/O port space Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 011/134] zd1211rw: fix NULL-deref at probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 117/134] fbdev: sti: don't select CONFIG_VT Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 045/134] power: supply: lp8788: prevent out of bounds array access Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 120/134] fs/xattr.c: zero out memory copied to userspace in getxattr Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 056/134] regulator: tps65023: Fix inverted core enable logic Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 044/134] vfio/type1: Remove locked page accounting workqueue Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 046/134] ARM: dts: at91: sama5d3_xplained: fix ADC vref Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 014/134] mtd: nand: fsmc: fix NAND width handling Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 094/134] net: ethernet: ucc_geth: fix MEM_PART_MURAM mode Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 013/134] usb: hub: Do not attempt to autosuspend disconnected devices Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 092/134] libata: reject passthrough WRITE SAME requests Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 019/134] cdc-acm: fix possible invalid access when processing notification Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 002/134] staging: comedi: jr3_pci: fix possible null pointer dereference Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 038/134] [media] uvcvideo: Fix empty packet statistic Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 112/134] um: Fix PTRACE_POKEUSER on x86_64 Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 083/134] x86/mm: Fix flush_tlb_page() on Xen Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 109/134] metag/uaccess: Check access_ok in strncpy_from_user Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 064/134] [media] ov2640: fix vflip control Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 123/134] net/mlx4_en: Change the error print to debug print Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 012/134] usb: hub: Fix error loop seen after hub communication errors Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 104/134] powerpc/eeh: Avoid use after free in eeh_handle_special_event() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 085/134] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 032/134] MIPS: Loongson-3: Select MIPS_L1_CACHE_SHIFT_6 Ben Hutchings
2017-08-21 2:24 ` Huacai Chen
2017-08-26 0:34 ` Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 005/134] ima: accept previously set IMA_NEW_FILE Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 043/134] PCI: Fix pci_mmap_fits() for HAVE_PCI_RESOURCE_TO_USER platforms Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 017/134] staging: iio: tsl2x7x_core: Fix standard deviation calculation Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 114/134] SMB3: Work around mount failure when using SMB3 dialect to Macs Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 052/134] ftrace: Fix removing of second function probe Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 078/134] dm btree: fix for dm_btree_find_lowest_key() Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 077/134] netfilter: ctnetlink: make it safer when updating ct->status Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 106/134] tcp: fix wraparound issue in tcp_lp Ben Hutchings
2017-08-18 13:13 ` [PATCH 3.16 022/134] pinctrl: sh-pfc: r8a7791: Fix SCIF2 pinmux data Ben Hutchings
2017-08-18 14:55 ` [PATCH 3.16 000/134] 3.16.47-rc1 review Guenter Roeck
2017-08-18 20:10 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170819092940.62513d5c@gmail.com \
--to=maksim.salau@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alviboi@gmail.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox