From: Greg KH <greg@kroah.com>
To: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
stable@vger.kernel.org, Thong Ho <thong.ho.px@rvc.renesas.com>
Subject: Re: [PATCH 4.4.y] drm: rcar-du: Fix crash in encoder failure error path
Date: Sun, 27 Aug 2017 14:21:39 +0200 [thread overview]
Message-ID: <20170827122139.GA2963@kroah.com> (raw)
In-Reply-To: <20170816085350.3180-3-nhan.nguyen.yb@renesas.com>
On Wed, Aug 16, 2017 at 03:53:48PM +0700, Nhan Nguyen wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> commit 05ee29e94acf0d4b3998c3f93374952de8f90176 upstream.
>
> When an encoder fails to initialize the driver prints an error message
> to the kernel log. The message contains the name of the encoder's DT
> node, which is NULL for internal encoders. Use the of_node_full_name()
> macro to avoid dereferencing a NULL pointer, print the output number to
> add more context to the error, and make sure we still own a reference to
> the encoder's DT node by delaying the of_node_put() call.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Signed-off-by: Thong Ho <thong.ho.px@rvc.renesas.com>
> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
I also added this to 4.9-stable.
next prev parent reply other threads:[~2017-08-27 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 8:53 [PATCH 4.4.y] drm: rcar-du: lvds: Fix PLL frequency-related configuration Nhan Nguyen
2017-08-16 8:53 ` [PATCH 4.4.y] drm: rcar-du: lvds: Rename PLLEN bit to PLLON Nhan Nguyen
2017-08-16 8:53 ` [PATCH 4.4.y] drm: rcar-du: Fix crash in encoder failure error path Nhan Nguyen
2017-08-27 12:21 ` Greg KH [this message]
2017-08-16 8:53 ` [PATCH 4.4.y] drm: rcar-du: Fix display timing controller parameter Nhan Nguyen
2017-08-27 12:22 ` Greg KH
2017-08-16 8:53 ` [PATCH 4.4.y] drm: rcar-du: Fix H/V sync signal polarity configuration Nhan Nguyen
2017-08-27 12:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827122139.GA2963@kroah.com \
--to=greg@kroah.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=nhan.nguyen.yb@renesas.com \
--cc=stable@vger.kernel.org \
--cc=thong.ho.px@rvc.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox