From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdH0Maf (ORCPT ); Sun, 27 Aug 2017 08:30:35 -0400 Date: Sun, 27 Aug 2017 14:30:39 +0200 From: Greg KH To: Krister Johansen Cc: stable@vger.kernel.org, acme@redhat.com, mhiramat@kernel.org, namhyung@kernel.org, jolsa@redhat.com, peterz@infradead.org Subject: Re: [PATCH 4.9] perf probe: Fix --funcs to show correct symbols for offline module Message-ID: <20170827123039.GD2963@kroah.com> References: <20170825230535.GA2615@templeofstupid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825230535.GA2615@templeofstupid.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Aug 25, 2017 at 04:05:35PM -0700, Krister Johansen wrote: > Hi Greg, > There's a bit more fallout from pulling in the patches we discussed in > this thread: > > https://lkml.org/lkml/2017/7/5/537 > > While those patches fixed the build, I didn't get a chance to run a full > set of tests on the result. Last week, when attempting to set a > kretprobe in a kernel module using 'perf probe' I hit an assertion that > triggers when you attempt to delete an object that's still in a tree. > > It turned out that the patch below was also pushed around the same time > as the others that had been pulled into 4.9, and so we'd missed a case > where a refcount was not getting correctly incremented. The patch below > is just a git cherry-pick of the commit from HEAD to the stable 4.9 > branch. This addressed the refcount assertion failure I was seeing. Thanks, now queued up. greg k-h