public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Megha Dey <megha.dey@linux.intel.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] crypto: x86/sha1 : Fix reads beyond the number of blocks passed
Date: Thu, 31 Aug 2017 08:03:59 +0200	[thread overview]
Message-ID: <20170831060359.GC7325@kroah.com> (raw)
In-Reply-To: <1504026511.29723.5.camel@megha-Z97X-UD7-TH>

On Tue, Aug 29, 2017 at 10:08:31AM -0700, Megha Dey wrote:
> On Tue, 2017-08-22 at 17:47 -0700, Greg KH wrote:
> > On Tue, Aug 22, 2017 at 05:41:03PM -0700, Megha Dey wrote:
> > > It was reported that the sha1 AVX2 function(sha1_transform_avx2) is
> > > reading ahead beyond its intended data, and causing a crash if the next
> > > block is beyond page boundary:
> > > http://marc.info/?l=linux-crypto-vger&m=149373371023377
> > > 
> > > This patch makes sure that there is no overflow for any buffer length.
> > > 
> > > It passes the tests written by Jan Stancek that revealed this problem:
> > > https://github.com/jstancek/sha1-avx2-crash
> > > 
> > > This patch fixes reads beyond the number of blocks in the same way it
> > > was done in commit 8861249c740fc4af9ddc5aee321eafefb960d7c6
> > > ("crypto: x86/sha1 : Fix reads beyond the number of blocks passed").
> > 
> > So all you really want is that specific commit added to the stable
> > kernels?  If so, what kernel tree(s)?
> 
> Hi Greg,
> The commit 8861249c740fc4af9ddc5aee321eafefb960d7c6 present in the
> mainline kernel does not apply cleanly to the stable kernel tree. Hence,
> I have submitted this patch with some minor changes for the stable tree.
> 
> I am not sure what you mean by which kernel trees.

There are lots of stable kernel trees being maintained at the moment,
see:
	https://www.kernel.org/category/releases.html

I was asking if any of those are applicable for this patch as well.

thanks,

greg k-h

  reply	other threads:[~2017-08-31  6:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  0:41 [PATCH] crypto: x86/sha1 : Fix reads beyond the number of blocks passed Megha Dey
2017-08-23  0:47 ` Greg KH
2017-08-29 17:08   ` Megha Dey
2017-08-31  6:03     ` Greg KH [this message]
2017-08-31  6:06       ` Greg KH
2017-08-31 17:35         ` Megha Dey
2017-09-04  9:34           ` Greg KH
2017-09-18  6:42             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831060359.GC7325@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=megha.dey@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox