From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:54360 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbdIDLXY (ORCPT ); Mon, 4 Sep 2017 07:23:24 -0400 From: Colin King To: Faisal Latif , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] RDMA/nes: do not leak uninitialized resp.reserved to userspace Date: Mon, 4 Sep 2017 12:23:16 +0100 Message-Id: <20170904112316.23832-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: From: Colin Ian King resp.reserved has not been initialized and so the copy_to_user (via ib_copy_to_udata) is copying uninitialized data from the stack back to user space which is a potential information leak. Fix this by setting resp.reserved to zero. Fixes: 3c2d774cad5b ("RDMA/nes: Add a driver for NetEffect RNICs") Cc: [2.6.24+] Signed-off-by: Colin Ian King --- drivers/infiniband/hw/nes/nes_verbs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c index f0dc5f4aa177..052c3822dfed 100644 --- a/drivers/infiniband/hw/nes/nes_verbs.c +++ b/drivers/infiniband/hw/nes/nes_verbs.c @@ -1666,6 +1666,7 @@ static struct ib_cq *nes_create_cq(struct ib_device *ibdev, resp.cq_id = nescq->hw_cq.cq_number; resp.cq_size = nescq->hw_cq.cq_size; resp.mmap_db_index = 0; + resp.reserved = 0; if (ib_copy_to_udata(udata, &resp, sizeof resp - sizeof resp.reserved)) { nes_free_resource(nesadapter, nesadapter->allocated_cqs, cq_num); kfree(nescq); -- 2.14.1