From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga14.intel.com ([192.55.52.115]:27011 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752315AbdIFUHS (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 6 Sep 2017 16:07:18 -0400
Date: Wed, 6 Sep 2017 16:13:02 -0400
From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, Akinobu Mita <akinobu.mita@gmail.com>,
        linux-nvme@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/4] nvme-pci: use appropriate initial chunk size for HMB
 allocation
Message-ID: <20170906201301.GG17331@localhost.localdomain>
References: <20170906135532.21358-1-hch@lst.de>
 <20170906135532.21358-3-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170906135532.21358-3-hch@lst.de>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Sep 06, 2017 at 03:55:30PM +0200, Christoph Hellwig wrote:
> From: Akinobu Mita <akinobu.mita@gmail.com>
> 
> The initial chunk size for host memory buffer allocation is currently
> PAGE_SIZE << MAX_ORDER.  MAX_ORDER order allocation is usually failed
> without CONFIG_DMA_CMA.  So the HMB allocation is retried with chunk size
> PAGE_SIZE << (MAX_ORDER - 1) in general, but there is no problem if the
> retry allocation works correctly.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> [hch: rebased]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Cc: stable@vger.kernel.org
> ---

Looks good.

Reviewed-by: Keith Busch <keith.busch@intel.com>