From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:35228 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751646AbdITO6n (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 20 Sep 2017 10:58:43 -0400
Date: Wed, 20 Sep 2017 16:58:53 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Bin Liu <b-liu@ti.com>, gkaiser@google.com, stable@vger.kernel.org,
        stable-commits@vger.kernel.org
Subject: Re: Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling
 again"" has been added to the 3.18-stable tree
Message-ID: <20170920145853.GB21881@kroah.com>
References: <15059036547773@kroah.com>
 <20170920132013.GA3864@uda0271908>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170920132013.GA3864@uda0271908>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Sep 20, 2017 at 08:20:13AM -0500, Bin Liu wrote:
> Hi Greg,
> 
> On Wed, Sep 20, 2017 at 12:34:14PM +0200, gregkh@linuxfoundation.org wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
> > 
> > to the 3.18-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      revert-usb-musb-fix-tx-fifo-flush-handling-again.patch
> > and it can be found in the queue-3.18 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> > 
> > 
> > From 817bdbb406234e405e01790dfc6fffd91a15367e Mon Sep 17 00:00:00 2001
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Date: Wed, 20 Sep 2017 12:31:05 +0200
> > Subject: [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
> > 
> > This reverts commit 98b91bfa5e478b9bf332f9f149b1c25ffd58f877 which is
> > commit 45d73860530a14c608f410b91c6c341777bfa85d upstream.
> > 
> > It should not have been applied to the 3.18-stable tree at all.
> 
> The original commit 45d73860530a14c608f410b91c6c341777bfa85d upstream
> does mention it is applicable to v4.4+,
> 
> 	Cc: stable@vger.kernel.org # v4.4+
> 
> but it doesn't have 'Fixes ...' line.
> 
> What is the best format of a commit message to help to prevent this
> incident happen again?

You did it right, I missed it when I was applying patches, sorry, my
fault.

greg k-h