From: Jason Gerecke <killertofu@gmail.com>
To: linuxwacom-devel@lists.sourceforge.net
Cc: Ping Cheng <pinglinux@gmail.com>, Aaron Skomra <skomra@gmail.com>,
stable <stable@vger.kernel.org>
Subject: [PATCH input-wacom 02/10] backport: HID: wacom: leds: Don't try to control the EKR's read-only LEDs
Date: Thu, 21 Sep 2017 09:25:00 -0700 [thread overview]
Message-ID: <20170921162508.12492-2-killertofu@gmail.com> (raw)
In-Reply-To: <20170921162508.12492-1-killertofu@gmail.com>
From: Aaron Armstrong Skomra <skomra@gmail.com>
Commit a50aac7193f1 introduces 'led.groups' and adds EKR support
for these groups. However, unlike the other devices with LEDs,
the EKR's LEDs are read-only and we shouldn't attempt to control
them in wacom_led_control().
See bug: https://sourceforge.net/p/linuxwacom/bugs/342/
Fixes: a50aac7193f1 ("backport: HID: wacom: leds: dynamically allocate LED groups")
Cc: stable <stable@vger.kernel.org> # 4.9
Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@wacom.com>
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
[jason.gerecke@wacom.com: Imported into input-wacom repository (74aebed6dc)]
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
[jason.gerecke@wacom.com: Backported from input-wacom repository (7a69536)]
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
3.17/wacom_sys.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/3.17/wacom_sys.c b/3.17/wacom_sys.c
index 2996d0d..8fd0b78 100644
--- a/3.17/wacom_sys.c
+++ b/3.17/wacom_sys.c
@@ -794,6 +794,9 @@ static int wacom_led_control(struct wacom *wacom)
if (!wacom->led.groups)
return -ENOTSUPP;
+ if (wacom->wacom_wac.features.type == REMOTE)
+ return -ENOTSUPP;
+
if (wacom->wacom_wac.pid) { /* wireless connected */
report_id = WAC_CMD_WL_LED_CONTROL;
buf_size = 13;
--
2.14.1
parent reply other threads:[~2017-09-21 16:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170921162508.12492-1-killertofu@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921162508.12492-2-killertofu@gmail.com \
--to=killertofu@gmail.com \
--cc=linuxwacom-devel@lists.sourceforge.net \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).