From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53348 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbdJDOj1 (ORCPT ); Wed, 4 Oct 2017 10:39:27 -0400 Date: Wed, 4 Oct 2017 16:39:35 +0200 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, Andrey Konovalov , linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect Message-ID: <20171004143935.GD13707@kroah.com> References: <20171004090113.24218-1-johan@kernel.org> <20171004090113.24218-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171004090113.24218-2-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Oct 04, 2017 at 11:01:12AM +0200, Johan Hovold wrote: > A clean-up patch removing removing two redundant NULL-checks from the > console disconnect handler inadvertently also removed a third check. > This could lead to the struct usb_serial being prematurely freed by the > console code when a driver accepts but does not register any ports for > an interface which also lacks endpoint descriptors. > > Fixes: 0e517c93dc02 ("USB: serial: console: clean up sanity checks") > Cc: stable # 4.11 > Reported-by: Andrey Konovalov > Signed-off-by: Johan Hovold Acked-by: Greg Kroah-Hartman