From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:35930 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751132AbdJDUPq (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 4 Oct 2017 16:15:46 -0400
Date: Wed, 4 Oct 2017 22:15:09 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, stable@vger.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        xen-devel@lists.xenproject.org, jgross@suse.com, krzk@kernel.org,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        David Vrabel <david.vrabel@citrix.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        Andrii Anisov <andrii_anisov@epam.com>,
        Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [STABLE-4.4, 3.18]: fix xen_swiotlb_dma_mmap prototype
Message-ID: <20171004201509.GA3856@kroah.com>
References: <20171004135140.3720000-1-arnd@arndb.de>
 <alpine.DEB.2.10.1710041000260.15203@sstabellini-ThinkPad-X260>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1710041000260.15203@sstabellini-ThinkPad-X260>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Oct 04, 2017 at 10:01:26AM -0700, Stefano Stabellini wrote:
> On Wed, 4 Oct 2017, Arnd Bergmann wrote:
> > xen_swiotlb_dma_mmap was backported from v4.10, but older
> > kernels before commit 00085f1efa38 ("dma-mapping: use unsigned long
> > for dma_attrs") use a different signature:
> > 
> > arm/xen/mm.c:202:10: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .mmap = xen_swiotlb_dma_mmap,
> >           ^~~~~~~~~~~~~~~~~~~~
> > arm/xen/mm.c:202:10: note: (near initialization for 'xen_swiotlb_dma_ops.mmap')
> > 
> > This adapts the patch to the old calling conventions.
> > 
> > Fixes: 2f0b82b1b830 ("swiotlb-xen: implement xen_swiotlb_dma_mmap callback")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Thanks, I've added this tag to the patch.

greg k-h