From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f45.google.com ([74.125.83.45]:45814 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbdJEEnx (ORCPT ); Thu, 5 Oct 2017 00:43:53 -0400 Received: by mail-pg0-f45.google.com with SMTP id b192so4598431pga.2 for ; Wed, 04 Oct 2017 21:43:53 -0700 (PDT) Date: Thu, 5 Oct 2017 10:13:50 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Viresh Kumar , Nishanth Menon , linux-pm@vger.kernel.org, Tobias Jordan , "4 . 3+" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / OPP: Add missing of_node_put(np) Message-ID: <20171005044350.GA18345@vireshk-i7> References: <3a82b2d3311e16f0f638de18bf0ee803540014a3.1507096875.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On 04-10-17, 09:42, Stephen Boyd wrote: > On 10/03/2017 11:05 PM, Viresh Kumar wrote: > > From: Tobias Jordan > > > > The for_each_available_child_of_node() loop in _of_add_opp_table_v2() > > doesn't drop the reference to "np" on errors. Fix that. > > > > Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings") > > Cc: 4.3+ # 4.3+ > > Signed-off-by: Tobias Jordan > > [ VK: Improved commit log. ] > > Signed-off-by: Viresh Kumar > > --- > > Reviewed-by: Stephen Boyd > > Looks like that opp_table->np = opp_np assignment in this function needs > to do an of_node_get() because the caller of this function puts the > pointer unconditionally. We only use that pointer (opp_table->np) in _managed_opp() to compare the address. Perhaps we don't need to do a of_node_get() there. -- viresh