stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Oester <kernel@linuxace.com>
To: stable@vger.kernel.org
Subject: Problem in current -stable kernels caused by 1064f874abc0
Date: Sat, 7 Oct 2017 13:33:35 -0700	[thread overview]
Message-ID: <20171007203335.GA3301@podesktop.linuxace.com> (raw)

Commit 1064f874abc0 ("mnt: Tuck mounts under others instead of
creating shadow/side mounts") was backported to various stable
kernels (4.4, 4.9, and 4.10 at least).  Unfortunately that patch
causes autofs mounts to fail with this error:

ls: cannot open directory '<automounted dir>': Too many levels of symbolic links

AFAICT, this was first reported here: https://lkml.org/lkml/2017/6/16/227.  

It seems these 8 additional upstream commits are required to prevent
such failure:

fb5f51c7425e: vfs: change d_manage() to take a struct path
c6609c0a1c34: vfs: add path_is_mountpoint() helper
01619491a5f0: vfs: add path_has_submounts()
74f504cff50b: autofs: change autofs4_expire_wait()/do_expire_wait() to take struct path
dd36a882e7ad: autofs: change autofs4_wait() to take struct path
cfaf86ab6ccd: autofs: use path_is_mountpoint() to fix unreliable d_mountpoint() checks
603597414734: autofs: use path_has_submounts() to fix unreliable have_submount() checks
f74e7b33c37e: vfs: remove unused have_submounts() function

These apply cleanly on top of 4.9.53, and solve the problem for me.

Interestingly, this was not a problem for us in CentOS 7.3, but only
became a problem in CentOS 7.4 when the chrony systemd service was changed
to use "ProtectHome=yes" in the service file.  We then started seeing
the symbolic link error on our autofs mounted /home.  If we start
chronyd after autofs, it works fine.  If we start chronyd before autofs
we get the error.  Similar for any other systemd service with that
systemd option enabled.  The relationship between that option and
these commits is baffling.

Can these please be backported to relevant -stable kernels?

Thanks,
Phil Oester

                 reply	other threads:[~2017-10-07 20:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171007203335.GA3301@podesktop.linuxace.com \
    --to=kernel@linuxace.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).