From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:44250 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751373AbdJLTSB (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 12 Oct 2017 15:18:01 -0400
Date: Thu, 12 Oct 2017 21:18:08 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, andreas.radke@mailbox.org,
        shuahkh@osg.samsung.com, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, patches@kernelci.org,
        ben.hutchings@codethink.co.uk, stable@vger.kernel.org
Subject: Re: [PATCH 4.9 000/105] 4.9.55-stable review
Message-ID: <20171012191808.GA17644@kroah.com>
References: <CADvbK_dTji3wdKM_31DGMvUNYiArUv--PkZBO8Fxnatp=fxJ-w@mail.gmail.com>
 <20171012171826.122420ea@workstation64.home>
 <CADvbK_eDqUG5+eKpBreVtkDR1nNik327aNsz-rbf4jE7YmjAig@mail.gmail.com>
 <20171012.101659.654720543467651527.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171012.101659.654720543467651527.davem@davemloft.net>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Oct 12, 2017 at 10:16:59AM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Thu, 12 Oct 2017 23:25:10 +0800
> 
> > pls try revert:
> > commit 02f7e4101092b88e57c73171174976c8a72a3eba
> > Author: Eric Dumazet <edumazet@google.com>
> > Date:   Mon Oct 2 12:20:51 2017 -0700
> > 
> >     socket, bpf: fix possible use after free
> > 
> > which caused a obvious issue in __sk_attach_prog():
> >         atomic_set(&fp->refcnt, 0);  <----
> > 
> >         if (!sk_filter_charge(sk, fp)) {
> >                 kfree(fp);
> >                 return -ENOMEM;
> >         }
> 
> Yeah this is the bad patch, my backport was buggy.
> 
> Greg, please revert.

No problem, I'll go revert it now.

Thanks to everyone for the good debugging and quick response.

greg k-h