[PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell

[PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell

[Chris Wilson]

The compiler warns:

	drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used

Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*

Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: David Weinehall <david.weinehall@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.12+
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index b307b6fe1ce3..115162549914 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
 			    int *n_entries)
 {
 	if (IS_BROADWELL(dev_priv)) {
-		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
-		return hsw_ddi_translations_fdi;
+		*n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
+		return bdw_ddi_translations_fdi;
 	} else if (IS_HASWELL(dev_priv)) {
 		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
 		return hsw_ddi_translations_fdi;
-- 
2.15.0.rc0

Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell

[Chris Wilson]

Quoting Chris Wilson (2017-10-13 16:47:35)
> The compiler warns:
> 
>         drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
> 
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
> 
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+

>From irc,
	j4ni> rb on ickle's pastebin patch
Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
-Chris

Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell

[Ville Syrjälä]

On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote:
> The compiler warns:
> 
> 	drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
> 
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
> 
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b307b6fe1ce3..115162549914 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
>  			    int *n_entries)
>  {
>  	if (IS_BROADWELL(dev_priv)) {
> -		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> -		return hsw_ddi_translations_fdi;
> +		*n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
> +		return bdw_ddi_translations_fdi;
>  	} else if (IS_HASWELL(dev_priv)) {
>  		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
>  		return hsw_ddi_translations_fdi;
> -- 
> 2.15.0.rc0

-- 
Ville Syrjälä
Intel OTC

Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell

[David Weinehall]

On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote:
> The compiler warns:
> 
> 	drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
> 
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*

Good catch, and thanks for fixing.

I noticed that the patch has already been reviewed and merged, so I
won't bother with an R-B.


Kind regards, David

> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b307b6fe1ce3..115162549914 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
>  			    int *n_entries)
>  {
>  	if (IS_BROADWELL(dev_priv)) {
> -		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> -		return hsw_ddi_translations_fdi;
> +		*n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
> +		return bdw_ddi_translations_fdi;
>  	} else if (IS_HASWELL(dev_priv)) {
>  		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
>  		return hsw_ddi_translations_fdi;
> -- 
> 2.15.0.rc0
>