Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jan Kara <jack@suse.cz>, eguan@redhat.com, stable@vger.kernel.org
Subject: Re: WTF: patch "[PATCH] quota: Generate warnings for DQUOT_SPACE_NOFAIL allocations" was seriously submitted to be applied to the 4.13-stable tree?
Date: Mon, 16 Oct 2017 15:23:13 +0200	[thread overview]
Message-ID: <20171016132313.GE9762@quack2.suse.cz> (raw)
In-Reply-To: <20171016124859.GA23225@kroah.com>

On Mon 16-10-17 14:48:59, Greg KH wrote:
> On Mon, Oct 16, 2017 at 12:42:02PM +0200, Jan Kara wrote:
> > Hi,
> > 
> > On Sun 15-10-17 15:34:33, gregkh@linuxfoundation.org wrote:
> > > The patch below was submitted to be applied to the 4.13-stable tree.
> > > 
> > > I fail to see how this patch meets the stable kernel rules as found at
> > > Documentation/process/stable-kernel-rules.rst.
> > > 
> > > I could be totally wrong, and if so, please respond to 
> > > <stable@vger.kernel.org> and let me know why this patch should be
> > > applied.  Otherwise, it is now dropped from my patch queues, never to be
> > > seen again.
> > 
> > So I guess your complaint is that the problem is not serious enough to
> > warrant a stable fix? My thinking was:
> > 
> > 1) This is a userspace visible regression caused by the below mentioned
> >    commit. 
> > 2) It can result in quota grace times not to be obeyed properly although in
> >    practice it would be hard to come up with a scenario where this would
> >    seriously matter (as they are likely to be setup properly on the next
> >    write).
> 
> 
> I would like to say I was thinking deep thoughts like this, but what I
> really was looking at was this in the patch:
> 
> > > Fixes: 7b9ca4c61bc278b771fb57d6290a31ab1fc7fdac
> 
> Which showd up in 4.14-rc1, and as such, doesn't make much sense for
> 4.13-stable :)

Bah :) Somehow I thought it has been merged already to 4.13-rc1.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2017-10-16 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15 13:34 WTF: patch "[PATCH] quota: Generate warnings for DQUOT_SPACE_NOFAIL allocations" was seriously submitted to be applied to the 4.13-stable tree? gregkh
2017-10-16 10:42 ` Jan Kara
2017-10-16 12:48   ` Greg KH
2017-10-16 13:23     ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016132313.GE9762@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=eguan@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox