[3.18-stable] Revert "usb: gadget: inode.c: fix unbalanced spin_lock in ep0

stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [3.18-stable] Revert "usb: gadget: inode.c: fix unbalanced spin_lock in ep0_write"
@ 2017-10-17 12:55 Ben Hutchings
  2017-10-17 14:15 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2017-10-17 12:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: stable, David Eccher, Felipe Balbi

Please revert commit abb540b53976 ("usb: gadget: inode.c: fix
unbalanced spin_lock in ep0_write") on the 3.18 stable branch.  The
upstream commit (b7bd98b7db9f) fixed a bug introduced in 4.0 by commit
96b62a571934 ("gadgetfs: really get rid of switching ->f_op"). 
Backporting it to older versions introduces a lock unbalance.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [3.18-stable] Revert "usb: gadget: inode.c: fix unbalanced spin_lock in ep0_write"
  2017-10-17 12:55 [3.18-stable] Revert "usb: gadget: inode.c: fix unbalanced spin_lock in ep0_write" Ben Hutchings
@ 2017-10-17 14:15 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-10-17 14:15 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: stable, David Eccher, Felipe Balbi

On Tue, Oct 17, 2017 at 01:55:58PM +0100, Ben Hutchings wrote:
> Please revert commit abb540b53976 ("usb: gadget: inode.c: fix
> unbalanced spin_lock in ep0_write") on the 3.18 stable branch.  The
> upstream commit (b7bd98b7db9f) fixed a bug introduced in 4.0 by commit
> 96b62a571934 ("gadgetfs: really get rid of switching ->f_op"). 
> Backporting it to older versions introduces a lock unbalance.

Ugh, you are right, this was my fault, and kbuild also complained about
this.

now reverted.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-17 14:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-17 12:55 [3.18-stable] Revert "usb: gadget: inode.c: fix unbalanced spin_lock in ep0_write" Ben Hutchings
2017-10-17 14:15 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).