From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:43618 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbdJRWwq (ORCPT ); Wed, 18 Oct 2017 18:52:46 -0400 Date: Wed, 18 Oct 2017 23:52:44 +0100 From: Al Viro To: Matthew Garrett Cc: linux-fsdevel@vger.kernel.org, David Howells , stable@vger.kernel.org Subject: Re: [PATCH V2] Fix mounting with MS_I_VERSION Message-ID: <20171018225244.GO21978@ZenIV.linux.org.uk> References: <20171018205626.25391-1-mjg59@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171018205626.25391-1-mjg59@google.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Oct 18, 2017 at 01:56:26PM -0700, Matthew Garrett wrote: > commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > internal superblock flags") reworked the flags that are passed through > do mount, and in the process dropped MS_I_VERSION. Confusingly, things > continue working if the i_version mount option is used because that's > directly passed to ext4 which interprets it, while iversion is turned > into MS_I_VERSION and dropped on the floor. This breaks IMA and EVM and > my heart. Pass SB_I_VERSION through, and update the consumers to use it > instead of MS_I_VERSION. Remaining bits applied on top of "vfs: fix mounting a filesystem with i_version". And AFAICS Cc:stable is wrong - e462ec50cb5fa is not in 4.13...