stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anisse Astier <anisse@astier.eu>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, Sasha Levin <alexander.levin@verizon.com>,
	Miklos Szeredi <mszeredi@redhat.com>,
	linux-unionfs@vger.kernel.org
Subject: Re: ca4c8a3a800039 ovl: treat special files like a regular fs
Date: Sat, 28 Oct 2017 14:33:24 +0200	[thread overview]
Message-ID: <20171028123324.GA8737@bifrost> (raw)
In-Reply-To: <20171027165316.GA21090@kroah.com>

On Fri, Oct 27, 2017 at 06:53:16PM +0200, Greg KH wrote:
> On Fri, Oct 27, 2017 at 05:20:48PM +0200, Anisse Astier wrote:
> > Hi,
> > 
> > Would it be possible to backport upstream commit
> > ca4c8a3a800039c2681d609c5b7491c1bd17c0a7 into 4.9 ?
> > 
> > 	From: Miklos Szeredi <mszeredi@redhat.com>
> > 	ovl: treat special files like a regular fs
> > 
> > 	No sense in opening special files on the underlying layers, they work just
> > 	as well if opened on the overlay.
> > 
> > 	Side effect is that it's no longer possible to connect one side of a pipe
> > 	opened on overlayfs with the other side opened on the underlying layer.
> > 
> > 
> > Before this it's impossible to do in-kernel resolution of a device file,
> > for example to mount or use dmsetup.
> 
> So, this adds a new feature, and does not fix a bug, right?  :)

That's correct. I thought earlier version behaved this way, after some
testing it seems they did not.

> 
> > Miklos, you say this might cause a behaviour change in a very
> > particular case; but did it cause an issue upstream since it was merged
> > in 4.10 ?
> > 
> > I also wish this was fixed in 4.1, so I did a tentative backport below.
> > What do you think Sasha, Miklos ?
> 
> What is preventing you from using a newer kernel like 4.13 if you rely
> on this new feature?

Nothing fancy here, that's what you get when using lots of non-upstream
code from a vendor.

Regards,

Anisse

      reply	other threads:[~2017-10-28 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 15:20 ca4c8a3a800039 ovl: treat special files like a regular fs Anisse Astier
2017-10-27 16:53 ` Greg KH
2017-10-28 12:33   ` Anisse Astier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171028123324.GA8737@bifrost \
    --to=anisse@astier.eu \
    --cc=alexander.levin@verizon.com \
    --cc=greg@kroah.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).