From: Johan Hovold <johan@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Viresh Kumar <vireshk@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration
Date: Sun, 29 Oct 2017 13:51:59 +0100 [thread overview]
Message-ID: <20171029125159.GA659@localhost> (raw)
In-Reply-To: <20171029124328.GE4240@vireshk-i7>
On Sun, Oct 29, 2017 at 06:13:28PM +0530, Viresh Kumar wrote:
> On 29-10-17, 13:01, Johan Hovold wrote:
> > Remove erroneous spi_master_put() after controller deregistration which
> > would access the already freed spi controller.
> >
> > Note that spi_unregister_master() drops our only controller reference.
> >
> > Fixes: ba3e67001b42 ("greybus: SPI: convert to a gpbridge driver")
> > Cc: stable <stable@vger.kernel.org> # 4.9
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> While looking at this I think I found another problem (I will send it as a
> separate patch later on) and this fixes it:
That's right, and I already posted a fix for that use-after-free:
https://lkml.kernel.org/r/20171029115625.32385-1-johan@kernel.org
Thanks,
Johan
next prev parent reply other threads:[~2017-10-29 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 12:01 [PATCH] staging: greybus: spilib: fix use-after-free after deregistration Johan Hovold
2017-10-29 12:43 ` Viresh Kumar
2017-10-29 12:51 ` Johan Hovold [this message]
2017-10-29 12:53 ` Viresh Kumar
2017-10-29 17:44 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029125159.GA659@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmfrfs@gmail.com \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).