From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:54616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdJ3MX3 (ORCPT ); Mon, 30 Oct 2017 08:23:29 -0400 From: Leon Romanovsky To: Doug Ledford Cc: linux-rdma@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , stable@vger.kernel.org Subject: [PATCH rdma-rc 3/3] RDMA/nldev: Enforce device index check for port callback Date: Mon, 30 Oct 2017 14:23:15 +0200 Message-Id: <20171030122315.21924-4-leon@kernel.org> In-Reply-To: <20171030122315.21924-1-leon@kernel.org> References: <20171030122315.21924-1-leon@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: From: Leon Romanovsky IB device index is nldev's handler and it should be always checked. Cc: stable@vger.kernel.org Fixes: c3f66f7b0052 ("RDMA/netlink: Implement nldev port doit callback") Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index 3ba24c428c3b..2fae850a3eff 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -214,7 +214,9 @@ static int nldev_port_get_doit(struct sk_buff *skb, struct nlmsghdr *nlh, err = nlmsg_parse(nlh, 0, tb, RDMA_NLDEV_ATTR_MAX - 1, nldev_policy, extack); - if (err || !tb[RDMA_NLDEV_ATTR_PORT_INDEX]) + if (err || + !tb[RDMA_NLDEV_ATTR_DEV_INDEX] || + !tb[RDMA_NLDEV_ATTR_PORT_INDEX]) return -EINVAL; index = nla_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]); -- 2.14.2