From: Greg KH <greg@kroah.com>
To: Long Li <longli@exchange.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Paul Meyer <Paul.Meyer@microsoft.com>,
Long Li <longli@microsoft.com>
Subject: Re: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file
Date: Wed, 1 Nov 2017 07:49:32 +0100 [thread overview]
Message-ID: <20171101064932.GA30717@kroah.com> (raw)
In-Reply-To: <20171031200235.9379-1-longli@exchange.microsoft.com>
On Tue, Oct 31, 2017 at 01:02:35PM -0700, Long Li wrote:
> From: Paul Meyer <Paul.Meyer@microsoft.com>
>
> While reading in more than one block (50) of KVP records, the allocation
> goes per block, but the reads used the total number of allocated records
> (without resetting the pointer/stream). This causes the records buffer to
> overrun when the refresh reads more than one block over the previous
> capacity (e.g. reading more than 100 KVP records whereas the in-memory
> database was empty before).
>
> Fix this by reading the correct number of KVP records from file each time.
>
> Signed-off-by: Paul Meyer <Paul.Meyer@microsoft.com>
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 66 ++++++++----------------------------------------
> 1 file changed, 10 insertions(+), 56 deletions(-)
When you version a patch, you always have to say what changed below the
--- line, as the documentation states to do...
v3? :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-01 6:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 20:02 [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file Long Li
2017-11-01 6:49 ` Greg KH [this message]
2017-11-01 18:39 ` Long Li
2017-11-01 18:54 ` Greg KH
2017-11-01 18:56 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101064932.GA30717@kroah.com \
--to=greg@kroah.com \
--cc=Paul.Meyer@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@exchange.microsoft.com \
--cc=longli@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).