[stable] drm/msm: Fix potential buffer overflow issue

[stable] drm/msm: Fix potential buffer overflow issue

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

These commits appear to be needed in all stable branches from 3.12
onward:

commit 4a630fadbb29d9efaedb525f1a8f7449ad107641
Author: Kasin Li <donglil@codeaurora.org>
Date:   Mon Jun 19 15:36:53 2017 -0600

    drm/msm: Fix potential buffer overflow issue

commit 65e93108891e571f177c202add9288eda9ac4100
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date:   Fri Jun 30 10:59:15 2017 +0300

    drm/msm: fix an integer overflow test

Ben.

-- 
Ben Hutchings
It is a miracle that curiosity survives formal education. - Albert
Einstein


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [stable] drm/msm: Fix potential buffer overflow issue

[Rob Clark]

On Tue, Oct 31, 2017 at 1:01 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> These commits appear to be needed in all stable branches from 3.12
> onward:
>
> commit 4a630fadbb29d9efaedb525f1a8f7449ad107641
> Author: Kasin Li <donglil@codeaurora.org>
> Date:   Mon Jun 19 15:36:53 2017 -0600
>
>     drm/msm: Fix potential buffer overflow issue
>
> commit 65e93108891e571f177c202add9288eda9ac4100
> Author: Dan Carpenter <dan.carpenter@oracle.com>
> Date:   Fri Jun 30 10:59:15 2017 +0300
>
>     drm/msm: fix an integer overflow test
>

I guess we do not need to go *all* the way back to 3.12, since drm/msm
was somewhat ahead of curve on the work to get upstream kernels
working on various snapdragon devices without needing a pile of other
patches.  Maybe going back one or two LTS's would make sense?  I think
apq8064 was probably the one that was working on upstream kernel the
earliest without extra patches needed.  I can double check when that
was, I think that puts a reasonable upper bound on how far back to
backport.

Let me know if you want help backporting these patches..

BR,
-R


> Ben.
>
> --
> Ben Hutchings
> It is a miracle that curiosity survives formal education. - Albert
> Einstein
>

Re: [stable] drm/msm: Fix potential buffer overflow issue

[Greg KH]

On Fri, Nov 03, 2017 at 06:54:50PM -0400, Rob Clark wrote:
> On Tue, Oct 31, 2017 at 1:01 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > These commits appear to be needed in all stable branches from 3.12
> > onward:
> >
> > commit 4a630fadbb29d9efaedb525f1a8f7449ad107641
> > Author: Kasin Li <donglil@codeaurora.org>
> > Date:   Mon Jun 19 15:36:53 2017 -0600
> >
> >     drm/msm: Fix potential buffer overflow issue
> >
> > commit 65e93108891e571f177c202add9288eda9ac4100
> > Author: Dan Carpenter <dan.carpenter@oracle.com>
> > Date:   Fri Jun 30 10:59:15 2017 +0300
> >
> >     drm/msm: fix an integer overflow test
> >
> 
> I guess we do not need to go *all* the way back to 3.12, since drm/msm
> was somewhat ahead of curve on the work to get upstream kernels
> working on various snapdragon devices without needing a pile of other
> patches.  Maybe going back one or two LTS's would make sense?  I think
> apq8064 was probably the one that was working on upstream kernel the
> earliest without extra patches needed.  I can double check when that
> was, I think that puts a reasonable upper bound on how far back to
> backport.
> 
> Let me know if you want help backporting these patches..

I've backported them to 3.18 with no problems, thanks.

greg k-h