From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>,
Sasha Levin <alexander.levin@verizon.com>
Subject: [PATCH 3.18 27/27] staging: r8712u: Fix Sparse warning in rtl871x_xmit.c
Date: Mon, 6 Nov 2017 12:28:12 +0100 [thread overview]
Message-ID: <20171106112737.691803099@linuxfoundation.org> (raw)
In-Reply-To: <20171106112736.529730803@linuxfoundation.org>
3.18-stable review patch. If anyone has any objections, please let me know.
------------------
From: Larry Finger <Larry.Finger@lwfinger.net>
[ Upstream commit 07222e535831b916221dd2a48a3047ec7e45dc72 ]
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl871x_xmit.c
drivers/staging/rtl8712/rtl871x_xmit.c:350:44: warning: restricted __le32 degrades to integer
drivers/staging/rtl8712/rtl871x_xmit.c:491:23: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8712/rtl871x_xmit.c:491:23: expected unsigned short [usertype] *fctrl
drivers/staging/rtl8712/rtl871x_xmit.c:491:23: got restricted __le16 *<noident>
drivers/staging/rtl8712/rtl871x_xmit.c:580:36: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8712/rtl871x_xmit.c:580:36: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/staging/rtl8712/rtl871x_xmit.c:580:36: got restricted __be16 [usertype] <noident>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -340,7 +340,8 @@ sint r8712_update_attrib(struct _adapter
/* if in MP_STATE, update pkt_attrib from mp_txcmd, and overwrite
* some settings above.*/
if (check_fwstate(pmlmepriv, WIFI_MP_STATE) == true)
- pattrib->priority = (txdesc.txdw1 >> QSEL_SHT) & 0x1f;
+ pattrib->priority =
+ (le32_to_cpu(txdesc.txdw1) >> QSEL_SHT) & 0x1f;
return _SUCCESS;
}
@@ -481,7 +482,7 @@ static sint make_wlanhdr(struct _adapter
struct ieee80211_hdr *pwlanhdr = (struct ieee80211_hdr *)hdr;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct qos_priv *pqospriv = &pmlmepriv->qospriv;
- u16 *fctrl = &pwlanhdr->frame_ctl;
+ __le16 *fctrl = &pwlanhdr->frame_ctl;
memset(hdr, 0, WLANHDR_OFFSET);
SetFrameSubType(fctrl, pattrib->subtype);
@@ -569,7 +570,7 @@ static sint r8712_put_snap(u8 *data, u16
snap->oui[0] = oui[0];
snap->oui[1] = oui[1];
snap->oui[2] = oui[2];
- *(u16 *)(data + SNAP_SIZE) = htons(h_proto);
+ *(__be16 *)(data + SNAP_SIZE) = htons(h_proto);
return SNAP_SIZE + sizeof(u16);
}
next prev parent reply other threads:[~2017-11-06 11:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 11:27 [PATCH 3.18 00/27] 3.18.80-stable review Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 01/27] blk-mq: fix race between timeout and freeing request Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 02/27] ALSA: timer: Add missing mutex lock for compat ioctls Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 03/27] ALSA: seq: Fix nested rwsem annotation for lockdep splat Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 04/27] cifs: check MaxPathNameComponentLength != 0 before using it Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 05/27] KEYS: return full count in keyring_read() if buffer is too small Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 06/27] KEYS: fix out-of-bounds read during ASN.1 parsing Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 07/27] ASoC: adau17x1: Workaround for noise bug in ADC Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 08/27] arm64: ensure __dump_instr() checks addr_limit Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 09/27] ARM: 8715/1: add a private asm/unaligned.h Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 10/27] ocfs2: fstrim: Fix start offset of first cluster group during fstrim Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 11/27] drm/msm: Fix potential buffer overflow issue Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 12/27] drm/msm: fix an integer overflow test Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 13/27] x86/microcode/intel: Disable late loading on model 79 Greg Kroah-Hartman
2017-11-06 11:27 ` [PATCH 3.18 14/27] mmc: s3cmci: include linux/interrupt.h for tasklet_struct Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 15/27] staging: rtl8712u: Fix endian settings for structs describing network packets Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 16/27] ext4: fix stripe-unaligned allocations Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 17/27] ext4: do not use stripe_width if it is not set Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 18/27] i2c: riic: correctly finish transfers Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 19/27] cx231xx: Fix I2C on Internal Master 3 Bus Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 20/27] xen/manage: correct return value check on xenbus_scanf() Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 21/27] platform/x86: intel_mid_thermal: Fix module autoload Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 22/27] staging: lustre: hsm: stack overrun in hai_dump_data_field Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 23/27] staging: lustre: ptlrpc: skip lock if export failed Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 24/27] s390/dasd: check for device error pointer within state change interrupts Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 25/27] bt8xx: fix memory leak Greg Kroah-Hartman
2017-11-06 11:28 ` [PATCH 3.18 26/27] xen: dont print error message in case of missing Xenstore entry Greg Kroah-Hartman
2017-11-06 11:28 ` Greg Kroah-Hartman [this message]
2017-11-06 14:35 ` [PATCH 3.18 00/27] 3.18.80-stable review Guenter Roeck
2017-11-06 14:44 ` Greg Kroah-Hartman
[not found] ` <CALpmF+H7QrgQDWdYCHHMD-kpxCrPVp14T72p51L8gNWfNq2x1g@mail.gmail.com>
2017-11-07 10:34 ` Greg Kroah-Hartman
2017-11-06 21:16 ` Guenter Roeck
2017-11-07 10:34 ` Greg Kroah-Hartman
2017-11-06 21:57 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106112737.691803099@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=alexander.levin@verizon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).