From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f177.google.com ([209.85.223.177]:56385 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbdKHU2H (ORCPT ); Wed, 8 Nov 2017 15:28:07 -0500 Date: Wed, 8 Nov 2017 12:28:03 -0800 From: Eric Biggers To: David Howells Cc: linux-crypto@vger.kernel.org, Herbert Xu , Tudor-Dan Ambarus , Mat Martineau , Salvatore Benedetto , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , stable@vger.kernel.org Subject: Re: [PATCH v2] lib/mpi: call cond_resched() from mpi_powm() loop Message-ID: <20171108202803.GA14292@gmail.com> References: <20171108191804.GA74965@gmail.com> <20171107221527.98433-1-ebiggers3@gmail.com> <25888.1510145417@warthog.procyon.org.uk> <17716.1510172232@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17716.1510172232@warthog.procyon.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Nov 08, 2017 at 08:17:12PM +0000, David Howells wrote: > Eric Biggers wrote: > > > This probably should be grouped with my series "crypto: dh - input validation > > fixes", as this is also a fix for Diffie-Hellman. I was actually expecting > > Herbert Xu to take these patches, as Diffie-Hellman is now part of the crypto > > API (crypto/dh.c); none of the patches actually touch security/keys/. > > Fine by me. > > > If you'd like to maintain the Diffie-Hellman implementation(s) you should > > get yourself added to MAINTAINERS for the relevant files. > > It touches the MPI lib, though, so it also potentially affects RSA and stuff, > which is why I introduced it to the kernel originally. > True, mpi_powm() might also be reachable by adding a key of type "asymmetric", in which case this fix would need to go to older kernels than v4.12. If I have a chance I'll see if I can find a reproducer. Eric