From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:52341 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbdKMLNE (ORCPT ); Mon, 13 Nov 2017 06:13:04 -0500 From: Johan Hovold To: Mark Brown Cc: Support Opensource , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Peter Ujfalusi , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold , stable , Adam Thomson Subject: [PATCH 1/2] ASoC: da7218: fix fix child-node lookup Date: Mon, 13 Nov 2017 12:12:55 +0100 Message-Id: <20171113111256.24140-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent codec node was also prematurely freed. Fixes: 4d50934abd22 ("ASoC: da7218: Add da7218 codec driver") Cc: stable # 4.5 Cc: Adam Thomson Signed-off-by: Johan Hovold --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index b2d42ec1dcd9..56564ce90cb6 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -2520,7 +2520,7 @@ static struct da7218_pdata *da7218_of_to_pdata(struct snd_soc_codec *codec) } if (da7218->dev_id == DA7218_DEV_ID) { - hpldet_np = of_find_node_by_name(np, "da7218_hpldet"); + hpldet_np = of_get_child_by_name(np, "da7218_hpldet"); if (!hpldet_np) return pdata; -- 2.15.0