From: Simon Guinot <simon.guinot@sequanux.org>
To: David Miller <davem@davemloft.net>
Cc: thomas.petazzoni@free-electrons.com, netdev@vger.kernel.org,
musv@gmx.de, andreas.tobler@cloudguard.ch,
gregory.clement@free-electrons.com,
antoine.tenart@free-electrons.com, mw@semihalf.com,
stable@vger.kernel.org
Subject: Re: [PATCH] net: mvneta: fix handling of the Tx descriptor counter
Date: Mon, 13 Nov 2017 16:36:14 +0100 [thread overview]
Message-ID: <20171113153614.GN18407@kw.sim.vm.gnt> (raw)
In-Reply-To: <20171113.235414.987480304119622711.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On Mon, Nov 13, 2017 at 11:54:14PM +0900, David Miller wrote:
> From: Simon Guinot <simon.guinot@sequanux.org>
> Date: Mon, 13 Nov 2017 15:51:15 +0100
>
> > IIUC the driver stops the queue if a threshold of 316 Tx descriptors is
> > reached (default and worst value).
>
> That's a lot of latency.
OK, then I'll keep the "tx_pending > 255" flushing condition. But note
there is no other software mechanism to limit the Tx latency inside the
mvneta driver. Should we add something ? And is that not rather the job
of the network stack to keep track of the latency and to limit the txq
size ?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-11-13 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPv3WKchs0gFsBmOzvpBL61HyS9+wWPk9miKB-=tmPF25xBC-A@mail.gmail.com>
2017-11-08 16:58 ` [PATCH] net: mvneta: fix handling of the Tx descriptor counter Simon Guinot
2017-11-08 17:03 ` David Laight
2017-11-08 17:17 ` Simon Guinot
2017-11-09 19:19 ` Andreas Tobler
2017-11-11 9:45 ` David Miller
2017-11-13 14:51 ` Simon Guinot
2017-11-13 14:54 ` David Miller
2017-11-13 15:36 ` Simon Guinot [this message]
2017-11-20 14:58 ` David Laight
2017-11-13 15:27 ` [PATCH v2] " Simon Guinot
2017-11-14 12:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113153614.GN18407@kw.sim.vm.gnt \
--to=simon.guinot@sequanux.org \
--cc=andreas.tobler@cloudguard.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=musv@gmx.de \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).