From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:52306 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbdKNLGd (ORCPT ); Tue, 14 Nov 2017 06:06:33 -0500 Date: Tue, 14 Nov 2017 12:05:46 +0100 From: Florian Westphal To: Sebastian Gottschall Cc: Florian Westphal , stable@vger.kernel.org, g.nault@alphalink.fr, pablo@netfilter.org Subject: Re: [PATCH 4.9.y] netfilter: nat: Revert "netfilter: nat: convert nat bysrc hash to rhashtable" Message-ID: <20171114110546.GA32514@breakpoint.cc> References: <20171112202347.14762-1-fw@strlen.de> <27ad57ea-74dc-adaf-de87-65ac43fc0e26@dd-wrt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <27ad57ea-74dc-adaf-de87-65ac43fc0e26@dd-wrt.com> Sender: stable-owner@vger.kernel.org List-ID: Sebastian Gottschall wrote: > this should belong to you. with the revert the kernel crashes for me > > [�� 24.838120] Unable to handle kernel NULL pointer dereference at virtual > address 00000055 > [�� 24.846193] pgd = c0004000 > [�� 24.848893] [00000055] *pgd=00000000 > [�� 24.852472] Internal error: Oops - BUG: 817 [#1] PREEMPT SMP ARM > [�� 24.858463] Modules linked in: xhci_plat_hcd xhci_pci xhci_hcd ohci_hcd > ehci_pci ehci_platform ehci_hcd usbcore usb_common nls_base qca_ssdk > gpio_pca953x mii_gpio wil6210 ath10k_pci ath10k_core ath9k ath9k_common > ath9k_hw ath mac80211 cfg80211 compat > [�� 24.880852] CPU: 2 PID: 0 Comm: swapper/2 Not tainted 4.9.62-rc1 #90 > [�� 24.887189] Hardware name: AnnapurnaLabs Alpine (Device Tree) > [�� 24.892921] task: ef029ac0 task.stack: ef05a000 > [�� 24.897444] PC is at nf_nat_cleanup_conntrack+0x4c/0x74 > [�� 24.902657] LR is at nf_nat_cleanup_conntrack+0x38/0x74 > [�� 24.907869] pc : []��� lr : []��� psr: 60000153 > [�� 24.907869] sp : ef05bb58� ip : ef05bb58� fp : ef05bb6c > [�� 24.919317] r10: ed230cc0� r9 : ed230c00� r8 : edf45800 > [�� 24.924529] r7 : ebcd2f00� r6 : ec33739e� r5 : c0892294� r4 : ebcd2f00 > [�� 24.931040] r3 : 00000000� r2 : 00000055� r1 : 00000000� r0 : c0892718 > [�� 24.937551] Flags: nZCv� IRQs on� FIQs off� Mode SVC_32� ISA ARM� Segment > user > [�� 24.944755] Control: 10c5387d� Table: 2bd1006a� DAC: 00000055 > [�� 24.950486] Process swapper/2 (pid: 0, stack limit = 0xef05a210) > [�� 24.956477] Stack: (0xef05bb58 to 0xef05c000) Guillaume, can you check what I missed? IIRC you said you had a revert for your 4.9 tree, correct?