* Re: [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups
2017-11-11 16:29 ` [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups Johan Hovold
@ 2017-11-13 20:15 ` Peter Ujfalusi
2017-11-14 23:53 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2017-11-13 20:15 UTC (permalink / raw)
To: Johan Hovold, Stephen Boyd
Cc: Andy Gross, David Brown, Michael Turquette, Tero Kristo,
linux-arm-msm, linux-clk, linux-omap, linux-kernel, stable
On 11/11/2017 06:29 PM, Johan Hovold wrote:
> Fix child node-lookup during probe, which ended up searching the whole
> device tree depth-first starting at parent rather than just matching on
> its children.
>
> Note that the original premature free of the parent node has already
> been fixed separately, but that fix was apparently never backported to
> stable.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> Fixes: 660e15519399 ("clk: ti: dra7-atl-clock: Fix of_node reference counting")
> Cc: stable <stable@vger.kernel.org> # 3.16: 660e15519399
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/clk/ti/clk-dra7-atl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index 13eb04f72389..148815470431 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -274,8 +274,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
>
> /* Get configuration for the ATL instances */
> snprintf(prop, sizeof(prop), "atl%u", i);
> - of_node_get(node);
> - cfg_node = of_find_node_by_name(node, prop);
> + cfg_node = of_get_child_by_name(node, prop);
> if (cfg_node) {
> ret = of_property_read_u32(cfg_node, "bws",
> &cdesc->bws);
>
--
Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups
2017-11-11 16:29 ` [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups Johan Hovold
2017-11-13 20:15 ` Peter Ujfalusi
@ 2017-11-14 23:53 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2017-11-14 23:53 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, David Brown, Michael Turquette, Tero Kristo,
linux-arm-msm, linux-clk, linux-omap, linux-kernel, stable,
Peter Ujfalusi
On 11/11, Johan Hovold wrote:
> Fix child node-lookup during probe, which ended up searching the whole
> device tree depth-first starting at parent rather than just matching on
> its children.
>
> Note that the original premature free of the parent node has already
> been fixed separately, but that fix was apparently never backported to
> stable.
>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> Fixes: 660e15519399 ("clk: ti: dra7-atl-clock: Fix of_node reference counting")
> Cc: stable <stable@vger.kernel.org> # 3.16: 660e15519399
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread